colin
/
bookstack
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
bookstack/app/App/Providers/ValidationRuleServiceProvid...

31 lines
951 B
PHP
Raw Normal View History

Service provider and other cleanup - Removed old 'exposeTranslations' system to instead use new component option system. - Extracted validation rules into their own service provider. - Cleaned up some formatting/comments in the repos.
2020-11-22 01:52:49 +08:00
<?php
Played around with a new app structure
2023-05-18 00:56:55 +08:00
namespace BookStack\App\Providers;
Service provider and other cleanup - Removed old 'exposeTranslations' system to instead use new component option system. - Extracted validation rules into their own service provider. - Cleaned up some formatting/comments in the repos.
2020-11-22 01:52:49 +08:00
Cleaned up logic within ImageRepo - Moved out extension check to ImageService as that seems more relevant. - Updated models to use static-style references instead of facade to align with common modern usage within the app. - Updated custom image_extension validation rule to use shared logic in image service.
2021-11-01 08:24:42 +08:00
use BookStack\Uploads\ImageService;
Service provider and other cleanup - Removed old 'exposeTranslations' system to instead use new component option system. - Extracted validation rules into their own service provider. - Cleaned up some formatting/comments in the repos.
2020-11-22 01:52:49 +08:00
use Illuminate\Support\Facades\Validator;
use Illuminate\Support\ServiceProvider;
Refactored app service providers Removed old pagination provider as url handling now achieved in a better way. Removed unused broadcast service provider. Moved view-based tweaks into specific provider. Reorganised provider config list.
2022-09-27 09:48:05 +08:00
class ValidationRuleServiceProvider extends ServiceProvider
Service provider and other cleanup - Removed old 'exposeTranslations' system to instead use new component option system. - Extracted validation rules into their own service provider. - Cleaned up some formatting/comments in the repos.
2020-11-22 01:52:49 +08:00
{
/**
* Register our custom validation rules when the application boots.
*/
public function boot(): void
{
Validator::extend('image_extension', function ($attribute, $value, $parameters, $validator) {
Cleaned up logic within ImageRepo - Moved out extension check to ImageService as that seems more relevant. - Updated models to use static-style references instead of facade to align with common modern usage within the app. - Updated custom image_extension validation rule to use shared logic in image service.
2021-11-01 08:24:42 +08:00
$extension = strtolower($value->getClientOriginalExtension());
Applied latest styleci changes
2021-11-01 21:26:02 +08:00
Cleaned up logic within ImageRepo - Moved out extension check to ImageService as that seems more relevant. - Updated models to use static-style references instead of facade to align with common modern usage within the app. - Updated custom image_extension validation rule to use shared logic in image service.
2021-11-01 08:24:42 +08:00
return ImageService::isExtensionSupported($extension);
Service provider and other cleanup - Removed old 'exposeTranslations' system to instead use new component option system. - Extracted validation rules into their own service provider. - Cleaned up some formatting/comments in the repos.
2020-11-22 01:52:49 +08:00
});
Validator::extend('safe_url', function ($attribute, $value, $parameters, $validator) {
$cleanLinkName = strtolower(trim($value));
Increased attachment link limit from 192 to 2k Added test to cover. Did attempt a 64k limit, but values over 2k significantly increase chance of other issues since this URL may be used in redirect headers. Would rather catch issues in-app. For #4044
2023-02-20 21:05:23 +08:00
$isJs = str_starts_with($cleanLinkName, 'javascript:');
$isData = str_starts_with($cleanLinkName, 'data:');
Apply fixes from StyleCI
2021-06-26 23:23:15 +08:00
Service provider and other cleanup - Removed old 'exposeTranslations' system to instead use new component option system. - Extracted validation rules into their own service provider. - Cleaned up some formatting/comments in the repos.
2020-11-22 01:52:49 +08:00
return !$isJs && !$isData;
});
}
}