diff --git a/app/Auth/Permissions/PermissionsRepo.php b/app/Auth/Permissions/PermissionsRepo.php index 4d191679d..988146700 100644 --- a/app/Auth/Permissions/PermissionsRepo.php +++ b/app/Auth/Permissions/PermissionsRepo.php @@ -57,6 +57,7 @@ class PermissionsRepo public function saveNewRole(array $roleData): Role { $role = $this->role->newInstance($roleData); + $role->mfa_enforced = ($roleData['mfa_enforced'] ?? 'false') === 'true'; $role->save(); $permissions = isset($roleData['permissions']) ? array_keys($roleData['permissions']) : []; @@ -90,6 +91,7 @@ class PermissionsRepo $this->assignRolePermissions($role, $permissions); $role->fill($roleData); + $role->mfa_enforced = ($roleData['mfa_enforced'] ?? 'false') === 'true'; $role->save(); $this->permissionService->buildJointPermissionForRole($role); Activity::add(ActivityType::ROLE_UPDATE, $role); diff --git a/app/Auth/Role.php b/app/Auth/Role.php index 94ba39d1d..dcd960948 100644 --- a/app/Auth/Role.php +++ b/app/Auth/Role.php @@ -18,6 +18,7 @@ use Illuminate\Database\Eloquent\Relations\HasMany; * @property string $description * @property string $external_auth_id * @property string $system_name + * @property bool $mfa_enforced */ class Role extends Model implements Loggable { diff --git a/app/Http/Middleware/EnforceMfaRequirements.php b/app/Http/Middleware/EnforceMfaRequirements.php new file mode 100644 index 000000000..957b42ae1 --- /dev/null +++ b/app/Http/Middleware/EnforceMfaRequirements.php @@ -0,0 +1,24 @@ +roles()->where('mfa_enforced', '=', true)->exists(); + // TODO - Run this after auth (If authenticated) + // TODO - Redirect user to setup MFA or verify via MFA. + // TODO - Store mfa_pass into session for future requests? + return $next($request); + } +} diff --git a/database/migrations/2021_07_03_085038_add_mfa_enforced_to_roles_table.php b/database/migrations/2021_07_03_085038_add_mfa_enforced_to_roles_table.php new file mode 100644 index 000000000..c14d47ea7 --- /dev/null +++ b/database/migrations/2021_07_03_085038_add_mfa_enforced_to_roles_table.php @@ -0,0 +1,32 @@ +boolean('mfa_enforced'); + }); + } + + /** + * Reverse the migrations. + * + * @return void + */ + public function down() + { + Schema::table('roles', function (Blueprint $table) { + $table->dropColumn('mfa_enforced'); + }); + } +} diff --git a/resources/lang/en/settings.php b/resources/lang/en/settings.php index 789ef9d1b..d9b4854fe 100755 --- a/resources/lang/en/settings.php +++ b/resources/lang/en/settings.php @@ -138,6 +138,7 @@ return [ 'role_details' => 'Role Details', 'role_name' => 'Role Name', 'role_desc' => 'Short Description of Role', + 'role_mfa_enforced' => 'Requires Multi-Factor Authentication', 'role_external_auth_id' => 'External Authentication IDs', 'role_system' => 'System Permissions', 'role_manage_users' => 'Manage users', diff --git a/resources/views/settings/roles/form.blade.php b/resources/views/settings/roles/form.blade.php index 604acbb16..d1a61f0cd 100644 --- a/resources/views/settings/roles/form.blade.php +++ b/resources/views/settings/roles/form.blade.php @@ -11,13 +11,16 @@