From 286f9b0c7d2d85613680af3198efc967104ab6d6 Mon Sep 17 00:00:00 2001 From: Dan Brown Date: Sun, 27 Nov 2016 19:37:57 +0000 Subject: [PATCH] Moved page tags to sidebar Fixed #238 --- resources/assets/sass/_blocks.scss | 5 ++++- resources/assets/sass/_lists.scss | 2 ++ resources/assets/sass/_pages.scss | 19 ++++++++++-------- resources/views/pages/page-display.blade.php | 20 ------------------- resources/views/pages/show.blade.php | 2 ++ .../views/pages/sidebar-tree-list.blade.php | 16 +++++++++++++++ 6 files changed, 35 insertions(+), 29 deletions(-) diff --git a/resources/assets/sass/_blocks.scss b/resources/assets/sass/_blocks.scss index 727633f75..7eb595d36 100644 --- a/resources/assets/sass/_blocks.scss +++ b/resources/assets/sass/_blocks.scss @@ -135,7 +135,10 @@ border-left: 3px solid #BBB; background-color: #EEE; padding: $-s; - display: flex; + display: block; + > * { + display: inline-block; + } &:before { font-family: 'Material-Design-Iconic-Font'; padding-right: $-s; diff --git a/resources/assets/sass/_lists.scss b/resources/assets/sass/_lists.scss index 54fd55dff..e98e5bfcd 100644 --- a/resources/assets/sass/_lists.scss +++ b/resources/assets/sass/_lists.scss @@ -110,6 +110,8 @@ border-left: 0px solid #FFF; background-color: #FFF; &.fixed { + background-color: #FFF; + z-index: 5; position: fixed; top: 0; padding-left: $-l; diff --git a/resources/assets/sass/_pages.scss b/resources/assets/sass/_pages.scss index 880a9fdcc..0052a3319 100755 --- a/resources/assets/sass/_pages.scss +++ b/resources/assets/sass/_pages.scss @@ -248,29 +248,32 @@ } .tag-display { - margin: $-xl $-m; - border: 1px solid #DDD; - min-width: 180px; - max-width: 320px; - opacity: 0.7; - z-index: 5; + width: 100%; + //opacity: 0.7; position: relative; table { width: 100%; margin: 0; padding: 0; } + tr:first-child td { + padding-top: 0; + } .heading th { padding: $-xs $-s; - color: #333; + color: rgba(100, 100, 100, 0.7); + border: 0; font-weight: 400; } td { border: 0; - border-bottom: 1px solid #DDD; + border-bottom: 1px solid #EEE; padding: $-xs $-s; color: #444; } + tr td:first-child { + padding-left:0; + } .tag-value { color: #888; } diff --git a/resources/views/pages/page-display.blade.php b/resources/views/pages/page-display.blade.php index 6ffe4b502..fb6ca3045 100644 --- a/resources/views/pages/page-display.blade.php +++ b/resources/views/pages/page-display.blade.php @@ -2,26 +2,6 @@

{{$page->name}}

- @if(count($page->tags) > 0) -
- - - - - - - - @foreach($page->tags as $tag) - - - @if($tag->value) @endif - - @endforeach - -
Page Tags
value) colspan="2" @endif>{{ $tag->name }}{{$tag->value}}
-
- @endif -
@if (isset($diff) && $diff) diff --git a/resources/views/pages/show.blade.php b/resources/views/pages/show.blade.php index af85075a2..50c6f5d2c 100644 --- a/resources/views/pages/show.blade.php +++ b/resources/views/pages/show.blade.php @@ -115,6 +115,8 @@ @endif + + @include('pages/sidebar-tree-list', ['book' => $book, 'sidebarTree' => $sidebarTree, 'pageNav' => $pageNav]) diff --git a/resources/views/pages/sidebar-tree-list.blade.php b/resources/views/pages/sidebar-tree-list.blade.php index 09d9b77f9..5309cb774 100644 --- a/resources/views/pages/sidebar-tree-list.blade.php +++ b/resources/views/pages/sidebar-tree-list.blade.php @@ -1,6 +1,22 @@
+ @if(isset($page) && $page->tags->count() > 0) +
+
Page Tags
+ + + @foreach($page->tags as $tag) + + + @if($tag->value) @endif + + @endforeach + +
value) colspan="2" @endif>{{ $tag->name }}{{$tag->value}}
+
+ @endif + @if (isset($page) && $page->attachments->count() > 0)
Attachments
@foreach($page->attachments as $attachment)