colin
/
bookstack
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Settings: Added test to cover setting category by view

This commit is contained in:
Dan Brown 2024-10-11 13:33:07 +01:00
parent a3d0f7478f
commit 4dc75bad05
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Settings/SettingController.php
View File

@ -58,7 +58,7 @@ class SettingController extends Controller
protected function ensureCategoryExists(string $category): void
{
if (!view()->exists('settings.categories.' . $category)) {
abort(404, 'Category not found');
abort(404);
}
}
}

13
tests/ThemeTest.php
View File

@ -451,6 +451,19 @@ END;
});
}
public function test_custom_settings_category_page_can_be_added_via_view_file()
{
$content = 'My SuperCustomSettings';
$this->usingThemeFolder(function (string $folder) use ($content) {
$viewDir = theme_path('settings/categories');
mkdir($viewDir, 0777, true);
file_put_contents($viewDir . '/beans.blade.php', $content);
$this->asAdmin()->get('/settings/beans')->assertSee($content);
});
}
protected function usingThemeFolder(callable $callback)
{
// Create a folder and configure a theme