Extracted shortcut text to language files

app/Http/Controllers/UserPreferencesController.php

@@ -41,7 +41,7 @@ class UserPreferencesController extends Controller
         setting()->putForCurrentUser('ui-shortcuts', $shortcuts->toJson());
         setting()->putForCurrentUser('ui-shortcuts-enabled', $enabled);
 
-        $this->showSuccessNotification('Shortcut preferences have been updated!');
+        $this->showSuccessNotification(trans('preferences.shortcuts_update_success'));
 
         return redirect('/preferences/shortcuts');
     }

resources/lang/en/common.php

@@ -25,6 +25,7 @@ return [
     'actions' => 'Actions',
     'view' => 'View',
     'view_all' => 'View All',
+    'new' => 'New',
     'create' => 'Create',
     'update' => 'Update',
     'edit' => 'Edit',
@@ -80,12 +81,14 @@ return [
     'none' => 'None',
 
     // Header
+    'homepage' => 'Homepage',
     'header_menu_expand' => 'Expand Header Menu',
     'profile_menu' => 'Profile Menu',
     'view_profile' => 'View Profile',
     'edit_profile' => 'Edit Profile',
     'dark_mode' => 'Dark Mode',
     'light_mode' => 'Light Mode',
+    'global_search' => 'Global Search',
 
     // Layout tabs
     'tab_info' => 'Info',

resources/lang/en/preferences.php

@@ -0,0 +1,18 @@
+<?php
+
+/**
+ * Text used for user-preference specific views within bookstack.
+ */
+
+return [
+    'shortcuts' => 'Shortcuts',
+    'shortcuts_interface' => 'Interface Keyboard Shortcuts',
+    'shortcuts_toggle_desc' => 'Here you can enable or disable keyboard system interface shortcuts, used for navigation and actions.',
+    'shortcuts_customize_desc' => 'You can customize each of the shortcuts below. Just press your desired key combination after selecting the input for a shortcut.',
+    'shortcuts_toggle_label' => 'Keyboard shortcuts enabled',
+    'shortcuts_section_navigation' => 'Navigation',
+    'shortcuts_section_actions' => 'Common Actions',
+    'shortcuts_save' => 'Save Shortcuts',
+    'shortcuts_overlay_desc' => 'Note: When shortcuts are enabled a helper overlay is available via pressing "?" which will highlight the available shortcuts for actions currently visible on the screen.',
+    'shortcuts_update_success' => 'Shortcut preferences have been updated!',
+];

resources/views/common/header.blade.php

@@ -93,7 +93,7 @@
                         <li>
                             <a href="{{ url('/preferences/shortcuts') }}" class="icon-item">
                                 @icon('shortcuts')
-                                <div>{{ 'Shortcuts' }}</div>
+                                <div>{{ trans('preferences.shortcuts') }}</div>
                             </a>
                         </li>
                         <li>

resources/views/users/preferences/shortcuts.blade.php

@@ -8,31 +8,28 @@
                 {{ method_field('put') }}
                 {{ csrf_field() }}
 
-                <h1 class="list-heading">Interface Keyboard Shortcuts</h1>
+                <h1 class="list-heading">{{ trans('preferences.shortcuts_interface') }}</h1>
 
                 <div class="flex-container-row items-center gap-m wrap mb-m">
                     <p class="flex mb-none min-width-m text-small text-muted">
-                        Here you can enable or disable keyboard system interface shortcuts, used for navigation
+                        {{ trans('preferences.shortcuts_toggle_desc') }}
-                        and actions.
+                        {{ trans('preferences.shortcuts_customize_desc') }}
-
-                        You can customize each of the shortcuts below. Just press your desired key combination
-                        after selecting the input for a shortcut.
                     </p>
                     <div class="flex min-width-m text-m-center">
                         @include('form.toggle-switch', [
                             'name' => 'enabled',
                             'value' => $enabled,
-                            'label' => 'Keyboard shortcuts enabled',
+                            'label' => trans('preferences.shortcuts_toggle_label'),
                         ])
                     </div>
                 </div>
 
                 <hr>
 
-                <h2 class="list-heading mb-m">Navigation</h2>
+                <h2 class="list-heading mb-m">{{ trans('preferences.shortcuts_section_navigation') }}</h2>
                 <div class="flex-container-row wrap gap-m mb-xl">
                     <div class="flex min-width-l item-list">
-                        @include('users.preferences.parts.shortcut-control', ['label' => 'Homepage', 'id' => 'home_view'])
+                        @include('users.preferences.parts.shortcut-control', ['label' => trans('common.homepage'), 'id' => 'home_view'])
                         @include('users.preferences.parts.shortcut-control', ['label' => trans('entities.shelves'), 'id' => 'shelves_view'])
                         @include('users.preferences.parts.shortcut-control', ['label' => trans('entities.books'), 'id' => 'books_view'])
                         @include('users.preferences.parts.shortcut-control', ['label' => trans('settings.settings'), 'id' => 'settings_view'])
@@ -41,13 +38,13 @@
                     <div class="flex min-width-l item-list">
                         @include('users.preferences.parts.shortcut-control', ['label' => trans('common.view_profile'), 'id' => 'profile_view'])
                         @include('users.preferences.parts.shortcut-control', ['label' => trans('auth.logout'), 'id' => 'logout'])
-                        @include('users.preferences.parts.shortcut-control', ['label' => 'Global Search', 'id' => 'global_search'])
+                        @include('users.preferences.parts.shortcut-control', ['label' => trans('common.global_search'), 'id' => 'global_search'])
                         @include('users.preferences.parts.shortcut-control', ['label' => trans('common.next'), 'id' => 'next'])
                         @include('users.preferences.parts.shortcut-control', ['label' => trans('common.previous'), 'id' => 'previous'])
                     </div>
                 </div>
 
-                <h2 class="list-heading mb-m">Common Actions</h2>
+                <h2 class="list-heading mb-m">{{ trans('preferences.shortcuts_section_actions') }}</h2>
                 <div class="flex-container-row wrap gap-m mb-xl">
                     <div class="flex min-width-l item-list">
                         @include('users.preferences.parts.shortcut-control', ['label' => trans('common.new'), 'id' => 'new'])
@@ -65,13 +62,10 @@
                     </div>
                 </div>
 
-                <p class="text-small text-muted">
+                <p class="text-small text-muted">{{ trans('preferences.shortcuts_overlay_desc') }}</p>
-                    Note: When shortcuts are enabled a helper overlay is available via pressing "?" which will
-                    highlight the available shortcuts for actions currently visible on the screen.
-                </p>
 
                 <div class="form-group text-right">
-                    <button class="button">{{ 'Save Shortcuts' }}</button>
+                    <button class="button">{{ trans('preferences.shortcuts_save') }}</button>
                 </div>
 
             </form>