colin
/
bookstack
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Attachment List: Fixed broken ctrl-click functionality 

Fixes #4782
This commit is contained in:
Dan Brown 2024-01-23 15:01:07 +00:00
parent a4fd825fe2
commit 788327fffb
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
resources/js/components/attachments-list.js
View File

@ -9,6 +9,8 @@ export class AttachmentsList extends Component {
setup() { setup() {
this.container = this.$el; this.container = this.$el;
this.fileLinks = this.$manyRefs.linkTypeFile;
this.setupListeners(); this.setupListeners();
} }
@ -27,8 +29,7 @@ export class AttachmentsList extends Component {
} }
addOpenQueryToLinks() { addOpenQueryToLinks() {
const links = this.container.querySelectorAll('a.attachment-file'); for (const link of this.fileLinks) {
for (const link of links) {
if (link.href.split('?')[1] !== 'open=true') { if (link.href.split('?')[1] !== 'open=true') {
link.href += '?open=true'; link.href += '?open=true';
link.setAttribute('target', '_blank'); link.setAttribute('target', '_blank');
@ -37,8 +38,7 @@ export class AttachmentsList extends Component {
} }
removeOpenQueryFromLinks() { removeOpenQueryFromLinks() {
const links = this.container.querySelectorAll('a.attachment-file'); for (const link of this.fileLinks) {
for (const link of links) {
link.href = link.href.split('?')[0]; link.href = link.href.split('?')[0];
link.removeAttribute('target'); link.removeAttribute('target');
} }

4
resources/views/attachments/list.blade.php
View File

@ -2,7 +2,9 @@
@foreach($attachments as $attachment) @foreach($attachments as $attachment)
<div class="attachment icon-list"> <div class="attachment icon-list">
<div class="split-icon-list-item attachment-{{ $attachment->external ? 'link' : 'file' }}"> <div class="split-icon-list-item attachment-{{ $attachment->external ? 'link' : 'file' }}">
<a href="{{ $attachment->getUrl() }}" @if($attachment->external) target="_blank" @endif> <a href="{{ $attachment->getUrl() }}"
refs="attachments-list@link-type-{{ $attachment->external ? 'link' : 'file' }}"
@if($attachment->external) target="_blank" @endif>
<div class="icon">@icon($attachment->external ? 'export' : 'file')</div> <div class="icon">@icon($attachment->external ? 'export' : 'file')</div>
<div class="label">{{ $attachment->name }}</div> <div class="label">{{ $attachment->name }}</div>
</a> </a>