From b9b500323947f30ce8e7b2e19287ddefc27c4edb Mon Sep 17 00:00:00 2001 From: Lachlan Tripolone Date: Fri, 11 Oct 2024 10:40:38 +1100 Subject: [PATCH] Refactor SettingController to validate categies by existing view files --- app/Settings/SettingController.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/Settings/SettingController.php b/app/Settings/SettingController.php index bdbc3c78a..6ecc2bd1d 100644 --- a/app/Settings/SettingController.php +++ b/app/Settings/SettingController.php @@ -9,8 +9,6 @@ use Illuminate\Http\Request; class SettingController extends Controller { - protected array $settingCategories = ['features', 'customization', 'registration']; - /** * Handle requests to the settings index path. */ @@ -59,8 +57,8 @@ class SettingController extends Controller protected function ensureCategoryExists(string $category): void { - if (!in_array($category, $this->settingCategories)) { - abort(404); + if (!view()->exists('settings.' . $category)) { + abort(404, 'Category not found'); } } }