colin
/
bookstack
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Added testing to cover next/previous navigation 

For #2511
This commit is contained in:
Dan Brown 2021-05-29 12:49:10 +01:00
parent 0cfff6ab6f
commit ed6ec341df
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
5 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/Http/Controllers/BookController.php
View File

@ -12,7 +12,6 @@ use BookStack\Exceptions\ImageUploadException;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Validation\ValidationException; use Illuminate\Validation\ValidationException;
use Throwable; use Throwable;
use Views;
class BookController extends Controller class BookController extends Controller
{ {

1
app/Http/Controllers/ChapterController.php
View File

@ -11,7 +11,6 @@ use BookStack\Exceptions\NotFoundException;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Validation\ValidationException; use Illuminate\Validation\ValidationException;
use Throwable; use Throwable;
use Views;
class ChapterController extends Controller class ChapterController extends Controller
{ {

1
app/Http/Controllers/PageController.php
View File

@ -14,7 +14,6 @@ use Exception;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Validation\ValidationException; use Illuminate\Validation\ValidationException;
use Throwable; use Throwable;
use Views;
class PageController extends Controller class PageController extends Controller
{ {

2
resources/views/partials/entity-sibling-navigation.blade.php
View File

@ -1,4 +1,4 @@
<div class="grid half collapse-xs items-center mb-m px-m no-row-gap fade-in-when-active print-hidden"> <div id="sibling-navigation" class="grid half collapse-xs items-center mb-m px-m no-row-gap fade-in-when-active print-hidden">
<div> <div>
@if($previous) @if($previous)
<a href="{{ $previous->getUrl() }}" class="outline-hover no-link-style block rounded"> <a href="{{ $previous->getUrl() }}" class="outline-hover no-link-style block rounded">

15
tests/Entity/BookTest.php
View File

@ -31,4 +31,19 @@ class BookTest extends TestCase
$redirectReq = $this->get($deleteReq->baseResponse->headers->get('location')); $redirectReq = $this->get($deleteReq->baseResponse->headers->get('location'));
$redirectReq->assertNotificationContains('Book Successfully Deleted'); $redirectReq->assertNotificationContains('Book Successfully Deleted');
} }
public function test_next_previous_navigation_controls_show_within_book_content()
{
$book = Book::query()->first();
$chapter = $book->chapters->first();
$resp = $this->asEditor()->get($chapter->getUrl());
$resp->assertElementContains('#sibling-navigation', 'Next');
$resp->assertElementContains('#sibling-navigation', $chapter->pages[0]->name);
$resp = $this->get($chapter->pages[0]->getUrl());
$resp->assertElementContains('#sibling-navigation', $chapter->pages[1]->name);
$resp->assertElementContains('#sibling-navigation', 'Previous');
$resp->assertElementContains('#sibling-navigation', $chapter->name);
}
} }