From f139cded789908efce3ac2ed1be26b947df647db Mon Sep 17 00:00:00 2001
From: Dan Brown ' . $text . '
' . implode('
', $faker->paragraphs(5)) . ''; - - return [ - 'name' => $faker->sentence, - 'slug' => Str::random(10), - 'html' => $html, - 'text' => strip_tags($html), - 'revision_count' => 1, - ]; -}); - -$factory->define(\BookStack\Auth\Role::class, function ($faker) { - return [ - 'display_name' => $faker->sentence(3), - 'description' => $faker->sentence(10), - ]; -}); - -$factory->define(\BookStack\Actions\Tag::class, function ($faker) { - return [ - 'name' => $faker->city, - 'value' => $faker->sentence(3), - ]; -}); - -$factory->define(\BookStack\Uploads\Image::class, function ($faker) { - return [ - 'name' => $faker->slug . '.jpg', - 'url' => $faker->url, - 'path' => $faker->url, - 'type' => 'gallery', - 'uploaded_to' => 0, - ]; -}); - -$factory->define(\BookStack\Actions\Comment::class, function ($faker) { - $text = $faker->paragraph(1); - $html = '' . $text . '
'; - - return [ - 'html' => $html, - 'text' => $text, - 'parent_id' => null, - ]; -}); diff --git a/database/factories/Uploads/ImageFactory.php b/database/factories/Uploads/ImageFactory.php new file mode 100644 index 000000000..c6d0e0801 --- /dev/null +++ b/database/factories/Uploads/ImageFactory.php @@ -0,0 +1,31 @@ + $this->faker->slug . '.jpg', + 'url' => $this->faker->url, + 'path' => $this->faker->url, + 'type' => 'gallery', + 'uploaded_to' => 0, + ]; + } +} diff --git a/database/seeds/.gitkeep b/database/seeders/.gitkeep similarity index 100% rename from database/seeds/.gitkeep rename to database/seeders/.gitkeep diff --git a/database/seeds/DatabaseSeeder.php b/database/seeders/DatabaseSeeder.php similarity index 92% rename from database/seeds/DatabaseSeeder.php rename to database/seeders/DatabaseSeeder.php index 069765eb4..21eaefb19 100644 --- a/database/seeds/DatabaseSeeder.php +++ b/database/seeders/DatabaseSeeder.php @@ -1,5 +1,7 @@ create(); + $editorUser = User::factory()->create(); $editorRole = Role::getRole('editor'); $editorUser->attachRole($editorRole); // Create a viewer user - $viewerUser = factory(User::class)->create(); + $viewerUser = User::factory()->create(); $role = Role::getRole('viewer'); $viewerUser->attachRole($role); $byData = ['created_by' => $editorUser->id, 'updated_by' => $editorUser->id, 'owned_by' => $editorUser->id]; - factory(\BookStack\Entities\Models\Book::class, 5)->create($byData) + \BookStack\Entities\Models\Book::factory()->count(5)->create($byData) ->each(function ($book) use ($byData) { - $chapters = factory(Chapter::class, 3)->create($byData) + $chapters = Chapter::factory()->count(3)->create($byData) ->each(function ($chapter) use ($book, $byData) { - $pages = factory(Page::class, 3)->make(array_merge($byData, ['book_id' => $book->id])); + $pages = Page::factory()->count(3)->make(array_merge($byData, ['book_id' => $book->id])); $chapter->pages()->saveMany($pages); }); - $pages = factory(Page::class, 3)->make($byData); + $pages = Page::factory()->count(3)->make($byData); $book->chapters()->saveMany($chapters); $book->pages()->saveMany($pages); }); - $largeBook = factory(\BookStack\Entities\Models\Book::class)->create(array_merge($byData, ['name' => 'Large book' . Str::random(10)])); - $pages = factory(Page::class, 200)->make($byData); - $chapters = factory(Chapter::class, 50)->make($byData); + $largeBook = \BookStack\Entities\Models\Book::factory()->create(array_merge($byData, ['name' => 'Large book' . Str::random(10)])); + $pages = Page::factory()->count(200)->make($byData); + $chapters = Chapter::factory()->count(50)->make($byData); $largeBook->pages()->saveMany($pages); $largeBook->chapters()->saveMany($chapters); - $shelves = factory(Bookshelf::class, 10)->create($byData); + $shelves = Bookshelf::factory()->count(10)->create($byData); $largeBook->shelves()->attach($shelves->pluck('id')); // Assign API permission to editor role and create an API key diff --git a/database/seeds/LargeContentSeeder.php b/database/seeders/LargeContentSeeder.php similarity index 60% rename from database/seeds/LargeContentSeeder.php rename to database/seeders/LargeContentSeeder.php index 535626b8f..2fbf4a5c9 100644 --- a/database/seeds/LargeContentSeeder.php +++ b/database/seeders/LargeContentSeeder.php @@ -1,5 +1,7 @@ create(); + $editorUser = User::factory()->create(); $editorRole = Role::getRole('editor'); $editorUser->attachRole($editorRole); - $largeBook = factory(\BookStack\Entities\Models\Book::class)->create(['name' => 'Large book' . Str::random(10), 'created_by' => $editorUser->id, 'updated_by' => $editorUser->id]); - $pages = factory(Page::class, 200)->make(['created_by' => $editorUser->id, 'updated_by' => $editorUser->id]); - $chapters = factory(Chapter::class, 50)->make(['created_by' => $editorUser->id, 'updated_by' => $editorUser->id]); + $largeBook = \BookStack\Entities\Models\Book::factory()->create(['name' => 'Large book' . Str::random(10), 'created_by' => $editorUser->id, 'updated_by' => $editorUser->id]); + $pages = Page::factory()->count(200)->make(['created_by' => $editorUser->id, 'updated_by' => $editorUser->id]); + $chapters = Chapter::factory()->count(50)->make(['created_by' => $editorUser->id, 'updated_by' => $editorUser->id]); $largeBook->pages()->saveMany($pages); $largeBook->chapters()->saveMany($chapters); app(PermissionService::class)->buildJointPermissions(); diff --git a/public/index.php b/public/index.php index 7e4ef97c7..c2f34d4bf 100644 --- a/public/index.php +++ b/public/index.php @@ -1,21 +1,33 @@ - */ +use Illuminate\Contracts\Http\Kernel; +use BookStack\Http\Request; + define('LARAVEL_START', microtime(true)); +/* +|-------------------------------------------------------------------------- +| Check If The Application Is Under Maintenance +|-------------------------------------------------------------------------- +| +| If the application is in maintenance / demo mode via the "down" command +| we will load this file so that any pre-rendered content can be shown +| instead of starting the framework, which could cause an exception. +| +*/ + +if (file_exists(__DIR__ . '/../storage/framework/maintenance.php')) { + require __DIR__ . '/../storage/framework/maintenance.php'; +} + /* |-------------------------------------------------------------------------- | Register The Auto Loader |-------------------------------------------------------------------------- | | Composer provides a convenient, automatically generated class loader for -| our application. We just need to utilize it! We'll simply require it -| into the script here so that we don't have to worry about manual -| loading any of our classes later on. It feels great to relax. +| this application. We just need to utilize it! We'll simply require it +| into the script here so we don't need to manually load our classes. | */ @@ -23,37 +35,22 @@ require __DIR__ . '/../vendor/autoload.php'; /* |-------------------------------------------------------------------------- -| Turn On The Lights +| Run The Application |-------------------------------------------------------------------------- | -| We need to illuminate PHP development, so let us turn on the lights. -| This bootstraps the framework and gets it ready for use, then it -| will load up this application so that we can run it and send -| the responses back to the browser and delight our users. +| Once we have the application, we can handle the incoming request using +| the application's HTTP kernel. Then, we will send the response back +| to this client's browser, allowing them to enjoy our application. | */ $app = require_once __DIR__ . '/../bootstrap/app.php'; -$app->alias('request', \BookStack\Http\Request::class); +$app->alias('request', Request::class); -/* -|-------------------------------------------------------------------------- -| Run The Application -|-------------------------------------------------------------------------- -| -| Once we have the application, we can handle the incoming request -| through the kernel, and send the associated response back to -| the client's browser allowing them to enjoy the creative -| and wonderful application we have prepared for them. -| -*/ +$kernel = $app->make(Kernel::class); -$kernel = $app->make(Illuminate\Contracts\Http\Kernel::class); +$response = tap($kernel->handle( + $request = Request::capture() +))->send(); -$response = $kernel->handle( - $request = \BookStack\Http\Request::capture() -); - -$response->send(); - -$kernel->terminate($request, $response); +$kernel->terminate($request, $response); \ No newline at end of file diff --git a/routes/api.php b/routes/api.php index 49521bb89..4ba499462 100644 --- a/routes/api.php +++ b/routes/api.php @@ -1,53 +1,64 @@ comment(Inspiring::quote()); +})->purpose('Display an inspiring quote'); diff --git a/routes/web.php b/routes/web.php index a5f35fb8a..419a1e7f5 100644 --- a/routes/web.php +++ b/routes/web.php @@ -1,287 +1,318 @@ 'auth'], function () { +Route::middleware('auth')->group(function () { // Secure images routing - Route::get('/uploads/images/{path}', 'Images\ImageController@showImage') + Route::get('/uploads/images/{path}', [Images\ImageController::class, 'showImage']) ->where('path', '.*$'); // API docs routes - Route::get('/api/docs', 'Api\ApiDocsController@display'); + Route::get('/api/docs', [Api\ApiDocsController::class, 'display']); - Route::get('/pages/recently-updated', 'PageController@showRecentlyUpdated'); + Route::get('/pages/recently-updated', [PageController::class, 'showRecentlyUpdated']); // Shelves - Route::get('/create-shelf', 'BookshelfController@create'); - Route::group(['prefix' => 'shelves'], function () { - Route::get('/', 'BookshelfController@index'); - Route::post('/', 'BookshelfController@store'); - Route::get('/{slug}/edit', 'BookshelfController@edit'); - Route::get('/{slug}/delete', 'BookshelfController@showDelete'); - Route::get('/{slug}', 'BookshelfController@show'); - Route::put('/{slug}', 'BookshelfController@update'); - Route::delete('/{slug}', 'BookshelfController@destroy'); - Route::get('/{slug}/permissions', 'BookshelfController@showPermissions'); - Route::put('/{slug}/permissions', 'BookshelfController@permissions'); - Route::post('/{slug}/copy-permissions', 'BookshelfController@copyPermissions'); + Route::get('/create-shelf', [BookshelfController::class, 'create']); + Route::prefix('shelves')->group(function () { + Route::get('/', [BookshelfController::class, 'index']); + Route::post('/', [BookshelfController::class, 'store']); + Route::get('/{slug}/edit', [BookshelfController::class, 'edit']); + Route::get('/{slug}/delete', [BookshelfController::class, 'showDelete']); + Route::get('/{slug}', [BookshelfController::class, 'show']); + Route::put('/{slug}', [BookshelfController::class, 'update']); + Route::delete('/{slug}', [BookshelfController::class, 'destroy']); + Route::get('/{slug}/permissions', [BookshelfController::class, 'showPermissions']); + Route::put('/{slug}/permissions', [BookshelfController::class, 'permissions']); + Route::post('/{slug}/copy-permissions', [BookshelfController::class, 'copyPermissions']); - Route::get('/{shelfSlug}/create-book', 'BookController@create'); - Route::post('/{shelfSlug}/create-book', 'BookController@store'); + Route::get('/{shelfSlug}/create-book', [BookController::class, 'create']); + Route::post('/{shelfSlug}/create-book', [BookController::class, 'store']); }); - Route::get('/create-book', 'BookController@create'); - Route::group(['prefix' => 'books'], function () { + Route::get('/create-book', [BookController::class, 'create']); + Route::prefix('books')->group(function () { // Books - Route::get('/', 'BookController@index'); - Route::post('/', 'BookController@store'); - Route::get('/{slug}/edit', 'BookController@edit'); - Route::put('/{slug}', 'BookController@update'); - Route::delete('/{id}', 'BookController@destroy'); - Route::get('/{slug}/sort-item', 'BookSortController@showItem'); - Route::get('/{slug}', 'BookController@show'); - Route::get('/{bookSlug}/permissions', 'BookController@showPermissions'); - Route::put('/{bookSlug}/permissions', 'BookController@permissions'); - Route::get('/{slug}/delete', 'BookController@showDelete'); - Route::get('/{bookSlug}/sort', 'BookSortController@show'); - Route::put('/{bookSlug}/sort', 'BookSortController@update'); - Route::get('/{bookSlug}/export/html', 'BookExportController@html'); - Route::get('/{bookSlug}/export/pdf', 'BookExportController@pdf'); - Route::get('/{bookSlug}/export/markdown', 'BookExportController@markdown'); - Route::get('/{bookSlug}/export/zip', 'BookExportController@zip'); - Route::get('/{bookSlug}/export/plaintext', 'BookExportController@plainText'); + Route::get('/', [BookController::class, 'index']); + Route::post('/', [BookController::class, 'store']); + Route::get('/{slug}/edit', [BookController::class, 'edit']); + Route::put('/{slug}', [BookController::class, 'update']); + Route::delete('/{id}', [BookController::class, 'destroy']); + Route::get('/{slug}/sort-item', [BookSortController::class, 'showItem']); + Route::get('/{slug}', [BookController::class, 'show']); + Route::get('/{bookSlug}/permissions', [BookController::class, 'showPermissions']); + Route::put('/{bookSlug}/permissions', [BookController::class, 'permissions']); + Route::get('/{slug}/delete', [BookController::class, 'showDelete']); + Route::get('/{bookSlug}/sort', [BookSortController::class, 'show']); + Route::put('/{bookSlug}/sort', [BookSortController::class, 'update']); + Route::get('/{bookSlug}/export/html', [BookExportController::class, 'html']); + Route::get('/{bookSlug}/export/pdf', [BookExportController::class, 'pdf']); + Route::get('/{bookSlug}/export/markdown', [BookExportController::class, 'markdown']); + Route::get('/{bookSlug}/export/zip', [BookExportController::class, 'zip']); + Route::get('/{bookSlug}/export/plaintext', [BookExportController::class, 'plainText']); // Pages - Route::get('/{bookSlug}/create-page', 'PageController@create'); - Route::post('/{bookSlug}/create-guest-page', 'PageController@createAsGuest'); - Route::get('/{bookSlug}/draft/{pageId}', 'PageController@editDraft'); - Route::post('/{bookSlug}/draft/{pageId}', 'PageController@store'); - Route::get('/{bookSlug}/page/{pageSlug}', 'PageController@show'); - Route::get('/{bookSlug}/page/{pageSlug}/export/pdf', 'PageExportController@pdf'); - Route::get('/{bookSlug}/page/{pageSlug}/export/html', 'PageExportController@html'); - Route::get('/{bookSlug}/page/{pageSlug}/export/markdown', 'PageExportController@markdown'); - Route::get('/{bookSlug}/page/{pageSlug}/export/plaintext', 'PageExportController@plainText'); - Route::get('/{bookSlug}/page/{pageSlug}/edit', 'PageController@edit'); - Route::get('/{bookSlug}/page/{pageSlug}/move', 'PageController@showMove'); - Route::put('/{bookSlug}/page/{pageSlug}/move', 'PageController@move'); - Route::get('/{bookSlug}/page/{pageSlug}/copy', 'PageController@showCopy'); - Route::post('/{bookSlug}/page/{pageSlug}/copy', 'PageController@copy'); - Route::get('/{bookSlug}/page/{pageSlug}/delete', 'PageController@showDelete'); - Route::get('/{bookSlug}/draft/{pageId}/delete', 'PageController@showDeleteDraft'); - Route::get('/{bookSlug}/page/{pageSlug}/permissions', 'PageController@showPermissions'); - Route::put('/{bookSlug}/page/{pageSlug}/permissions', 'PageController@permissions'); - Route::put('/{bookSlug}/page/{pageSlug}', 'PageController@update'); - Route::delete('/{bookSlug}/page/{pageSlug}', 'PageController@destroy'); - Route::delete('/{bookSlug}/draft/{pageId}', 'PageController@destroyDraft'); + Route::get('/{bookSlug}/create-page', [PageController::class, 'create']); + Route::post('/{bookSlug}/create-guest-page', [PageController::class, 'createAsGuest']); + Route::get('/{bookSlug}/draft/{pageId}', [PageController::class, 'editDraft']); + Route::post('/{bookSlug}/draft/{pageId}', [PageController::class, 'store']); + Route::get('/{bookSlug}/page/{pageSlug}', [PageController::class, 'show']); + Route::get('/{bookSlug}/page/{pageSlug}/export/pdf', [PageExportController::class, 'pdf']); + Route::get('/{bookSlug}/page/{pageSlug}/export/html', [PageExportController::class, 'html']); + Route::get('/{bookSlug}/page/{pageSlug}/export/markdown', [PageExportController::class, 'markdown']); + Route::get('/{bookSlug}/page/{pageSlug}/export/plaintext', [PageExportController::class, 'plainText']); + Route::get('/{bookSlug}/page/{pageSlug}/edit', [PageController::class, 'edit']); + Route::get('/{bookSlug}/page/{pageSlug}/move', [PageController::class, 'showMove']); + Route::put('/{bookSlug}/page/{pageSlug}/move', [PageController::class, 'move']); + Route::get('/{bookSlug}/page/{pageSlug}/copy', [PageController::class, 'showCopy']); + Route::post('/{bookSlug}/page/{pageSlug}/copy', [PageController::class, 'copy']); + Route::get('/{bookSlug}/page/{pageSlug}/delete', [PageController::class, 'showDelete']); + Route::get('/{bookSlug}/draft/{pageId}/delete', [PageController::class, 'showDeleteDraft']); + Route::get('/{bookSlug}/page/{pageSlug}/permissions', [PageController::class, 'showPermissions']); + Route::put('/{bookSlug}/page/{pageSlug}/permissions', [PageController::class, 'permissions']); + Route::put('/{bookSlug}/page/{pageSlug}', [PageController::class, 'update']); + Route::delete('/{bookSlug}/page/{pageSlug}', [PageController::class, 'destroy']); + Route::delete('/{bookSlug}/draft/{pageId}', [PageController::class, 'destroyDraft']); // Revisions - Route::get('/{bookSlug}/page/{pageSlug}/revisions', 'PageRevisionController@index'); - Route::get('/{bookSlug}/page/{pageSlug}/revisions/{revId}', 'PageRevisionController@show'); - Route::get('/{bookSlug}/page/{pageSlug}/revisions/{revId}/changes', 'PageRevisionController@changes'); - Route::put('/{bookSlug}/page/{pageSlug}/revisions/{revId}/restore', 'PageRevisionController@restore'); - Route::delete('/{bookSlug}/page/{pageSlug}/revisions/{revId}/delete', 'PageRevisionController@destroy'); + Route::get('/{bookSlug}/page/{pageSlug}/revisions', [PageRevisionController::class, 'index']); + Route::get('/{bookSlug}/page/{pageSlug}/revisions/{revId}', [PageRevisionController::class, 'show']); + Route::get('/{bookSlug}/page/{pageSlug}/revisions/{revId}/changes', [PageRevisionController::class, 'changes']); + Route::put('/{bookSlug}/page/{pageSlug}/revisions/{revId}/restore', [PageRevisionController::class, 'restore']); + Route::delete('/{bookSlug}/page/{pageSlug}/revisions/{revId}/delete', [PageRevisionController::class, 'destroy']); // Chapters - Route::get('/{bookSlug}/chapter/{chapterSlug}/create-page', 'PageController@create'); - Route::post('/{bookSlug}/chapter/{chapterSlug}/create-guest-page', 'PageController@createAsGuest'); - Route::get('/{bookSlug}/create-chapter', 'ChapterController@create'); - Route::post('/{bookSlug}/create-chapter', 'ChapterController@store'); - Route::get('/{bookSlug}/chapter/{chapterSlug}', 'ChapterController@show'); - Route::put('/{bookSlug}/chapter/{chapterSlug}', 'ChapterController@update'); - Route::get('/{bookSlug}/chapter/{chapterSlug}/move', 'ChapterController@showMove'); - Route::put('/{bookSlug}/chapter/{chapterSlug}/move', 'ChapterController@move'); - Route::get('/{bookSlug}/chapter/{chapterSlug}/edit', 'ChapterController@edit'); - Route::get('/{bookSlug}/chapter/{chapterSlug}/permissions', 'ChapterController@showPermissions'); - Route::get('/{bookSlug}/chapter/{chapterSlug}/export/pdf', 'ChapterExportController@pdf'); - Route::get('/{bookSlug}/chapter/{chapterSlug}/export/html', 'ChapterExportController@html'); - Route::get('/{bookSlug}/chapter/{chapterSlug}/export/markdown', 'ChapterExportController@markdown'); - Route::get('/{bookSlug}/chapter/{chapterSlug}/export/plaintext', 'ChapterExportController@plainText'); - Route::put('/{bookSlug}/chapter/{chapterSlug}/permissions', 'ChapterController@permissions'); - Route::get('/{bookSlug}/chapter/{chapterSlug}/delete', 'ChapterController@showDelete'); - Route::delete('/{bookSlug}/chapter/{chapterSlug}', 'ChapterController@destroy'); + Route::get('/{bookSlug}/chapter/{chapterSlug}/create-page', [PageController::class, 'create']); + Route::post('/{bookSlug}/chapter/{chapterSlug}/create-guest-page', [PageController::class, 'createAsGuest']); + Route::get('/{bookSlug}/create-chapter', [ChapterController::class, 'create']); + Route::post('/{bookSlug}/create-chapter', [ChapterController::class, 'store']); + Route::get('/{bookSlug}/chapter/{chapterSlug}', [ChapterController::class, 'show']); + Route::put('/{bookSlug}/chapter/{chapterSlug}', [ChapterController::class, 'update']); + Route::get('/{bookSlug}/chapter/{chapterSlug}/move', [ChapterController::class, 'showMove']); + Route::put('/{bookSlug}/chapter/{chapterSlug}/move', [ChapterController::class, 'move']); + Route::get('/{bookSlug}/chapter/{chapterSlug}/edit', [ChapterController::class, 'edit']); + Route::get('/{bookSlug}/chapter/{chapterSlug}/permissions', [ChapterController::class, 'showPermissions']); + Route::get('/{bookSlug}/chapter/{chapterSlug}/export/pdf', [ChapterExportController::class, 'pdf']); + Route::get('/{bookSlug}/chapter/{chapterSlug}/export/html', [ChapterExportController::class, 'html']); + Route::get('/{bookSlug}/chapter/{chapterSlug}/export/markdown', [ChapterExportController::class, 'markdown']); + Route::get('/{bookSlug}/chapter/{chapterSlug}/export/plaintext', [ChapterExportController::class, 'plainText']); + Route::put('/{bookSlug}/chapter/{chapterSlug}/permissions', [ChapterController::class, 'permissions']); + Route::get('/{bookSlug}/chapter/{chapterSlug}/delete', [ChapterController::class, 'showDelete']); + Route::delete('/{bookSlug}/chapter/{chapterSlug}', [ChapterController::class, 'destroy']); }); // User Profile routes - Route::get('/user/{slug}', 'UserProfileController@show'); + Route::get('/user/{slug}', [UserProfileController::class, 'show']); // Image routes - Route::get('/images/gallery', 'Images\GalleryImageController@list'); - Route::post('/images/gallery', 'Images\GalleryImageController@create'); - Route::get('/images/drawio', 'Images\DrawioImageController@list'); - Route::get('/images/drawio/base64/{id}', 'Images\DrawioImageController@getAsBase64'); - Route::post('/images/drawio', 'Images\DrawioImageController@create'); - Route::get('/images/edit/{id}', 'Images\ImageController@edit'); - Route::put('/images/{id}', 'Images\ImageController@update'); - Route::delete('/images/{id}', 'Images\ImageController@destroy'); + Route::get('/images/gallery', [Images\GalleryImageController::class, 'list']); + Route::post('/images/gallery', [Images\GalleryImageController::class, 'create']); + Route::get('/images/drawio', [Images\DrawioImageController::class, 'list']); + Route::get('/images/drawio/base64/{id}', [Images\DrawioImageController::class, 'getAsBase64']); + Route::post('/images/drawio', [Images\DrawioImageController::class, 'create']); + Route::get('/images/edit/{id}', [Images\ImageController::class, 'edit']); + Route::put('/images/{id}', [Images\ImageController::class, 'update']); + Route::delete('/images/{id}', [Images\ImageController::class, 'destroy']); // Attachments routes - Route::get('/attachments/{id}', 'AttachmentController@get'); - Route::post('/attachments/upload', 'AttachmentController@upload'); - Route::post('/attachments/upload/{id}', 'AttachmentController@uploadUpdate'); - Route::post('/attachments/link', 'AttachmentController@attachLink'); - Route::put('/attachments/{id}', 'AttachmentController@update'); - Route::get('/attachments/edit/{id}', 'AttachmentController@getUpdateForm'); - Route::get('/attachments/get/page/{pageId}', 'AttachmentController@listForPage'); - Route::put('/attachments/sort/page/{pageId}', 'AttachmentController@sortForPage'); - Route::delete('/attachments/{id}', 'AttachmentController@delete'); + Route::get('/attachments/{id}', [AttachmentController::class, 'get']); + Route::post('/attachments/upload', [AttachmentController::class, 'upload']); + Route::post('/attachments/upload/{id}', [AttachmentController::class, 'uploadUpdate']); + Route::post('/attachments/link', [AttachmentController::class, 'attachLink']); + Route::put('/attachments/{id}', [AttachmentController::class, 'update']); + Route::get('/attachments/edit/{id}', [AttachmentController::class, 'getUpdateForm']); + Route::get('/attachments/get/page/{pageId}', [AttachmentController::class, 'listForPage']); + Route::put('/attachments/sort/page/{pageId}', [AttachmentController::class, 'sortForPage']); + Route::delete('/attachments/{id}', [AttachmentController::class, 'delete']); // AJAX routes - Route::put('/ajax/page/{id}/save-draft', 'PageController@saveDraft'); - Route::get('/ajax/page/{id}', 'PageController@getPageAjax'); - Route::delete('/ajax/page/{id}', 'PageController@ajaxDestroy'); + Route::put('/ajax/page/{id}/save-draft', [PageController::class, 'saveDraft']); + Route::get('/ajax/page/{id}', [PageController::class, 'getPageAjax']); + Route::delete('/ajax/page/{id}', [PageController::class, 'ajaxDestroy']); // Tag routes (AJAX) - Route::group(['prefix' => 'ajax/tags'], function () { - Route::get('/suggest/names', 'TagController@getNameSuggestions'); - Route::get('/suggest/values', 'TagController@getValueSuggestions'); + Route::prefix('ajax/tags')->group(function () { + Route::get('/suggest/names', [TagController::class, 'getNameSuggestions']); + Route::get('/suggest/values', [TagController::class, 'getValueSuggestions']); }); - Route::get('/ajax/search/entities', 'SearchController@searchEntitiesAjax'); + Route::get('/ajax/search/entities', [SearchController::class, 'searchEntitiesAjax']); // Comments - Route::post('/comment/{pageId}', 'CommentController@savePageComment'); - Route::put('/comment/{id}', 'CommentController@update'); - Route::delete('/comment/{id}', 'CommentController@destroy'); + Route::post('/comment/{pageId}', [CommentController::class, 'savePageComment']); + Route::put('/comment/{id}', [CommentController::class, 'update']); + Route::delete('/comment/{id}', [CommentController::class, 'destroy']); // Links - Route::get('/link/{id}', 'PageController@redirectFromLink'); + Route::get('/link/{id}', [PageController::class, 'redirectFromLink']); // Search - Route::get('/search', 'SearchController@search'); - Route::get('/search/book/{bookId}', 'SearchController@searchBook'); - Route::get('/search/chapter/{bookId}', 'SearchController@searchChapter'); - Route::get('/search/entity/siblings', 'SearchController@searchSiblings'); + Route::get('/search', [SearchController::class, 'search']); + Route::get('/search/book/{bookId}', [SearchController::class, 'searchBook']); + Route::get('/search/chapter/{bookId}', [SearchController::class, 'searchChapter']); + Route::get('/search/entity/siblings', [SearchController::class, 'searchSiblings']); // User Search - Route::get('/search/users/select', 'UserSearchController@forSelect'); + Route::get('/search/users/select', [UserSearchController::class, 'forSelect']); // Template System - Route::get('/templates', 'PageTemplateController@list'); - Route::get('/templates/{templateId}', 'PageTemplateController@get'); + Route::get('/templates', [PageTemplateController::class, 'list']); + Route::get('/templates/{templateId}', [PageTemplateController::class, 'get']); // Favourites - Route::get('/favourites', 'FavouriteController@index'); - Route::post('/favourites/add', 'FavouriteController@add'); - Route::post('/favourites/remove', 'FavouriteController@remove'); + Route::get('/favourites', [FavouriteController::class, 'index']); + Route::post('/favourites/add', [FavouriteController::class, 'add']); + Route::post('/favourites/remove', [FavouriteController::class, 'remove']); // Other Pages - Route::get('/', 'HomeController@index'); - Route::get('/home', 'HomeController@index'); - Route::get('/custom-head-content', 'HomeController@customHeadContent'); + Route::get('/', [HomeController::class, 'index']); + Route::get('/home', [HomeController::class, 'index']); + Route::get('/custom-head-content', [HomeController::class, 'customHeadContent']); // Settings - Route::group(['prefix' => 'settings'], function () { - Route::get('/', 'SettingController@index')->name('settings'); - Route::post('/', 'SettingController@update'); + Route::prefix('settings')->group(function () { + Route::get('/', [SettingController::class, 'index'])->name('settings'); + Route::post('/', [SettingController::class, 'update']); // Maintenance - Route::get('/maintenance', 'MaintenanceController@index'); - Route::delete('/maintenance/cleanup-images', 'MaintenanceController@cleanupImages'); - Route::post('/maintenance/send-test-email', 'MaintenanceController@sendTestEmail'); + Route::get('/maintenance', [MaintenanceController::class, 'index']); + Route::delete('/maintenance/cleanup-images', [MaintenanceController::class, 'cleanupImages']); + Route::post('/maintenance/send-test-email', [MaintenanceController::class, 'sendTestEmail']); // Recycle Bin - Route::get('/recycle-bin', 'RecycleBinController@index'); - Route::post('/recycle-bin/empty', 'RecycleBinController@empty'); - Route::get('/recycle-bin/{id}/destroy', 'RecycleBinController@showDestroy'); - Route::delete('/recycle-bin/{id}', 'RecycleBinController@destroy'); - Route::get('/recycle-bin/{id}/restore', 'RecycleBinController@showRestore'); - Route::post('/recycle-bin/{id}/restore', 'RecycleBinController@restore'); + Route::get('/recycle-bin', [RecycleBinController::class, 'index']); + Route::post('/recycle-bin/empty', [RecycleBinController::class, 'empty']); + Route::get('/recycle-bin/{id}/destroy', [RecycleBinController::class, 'showDestroy']); + Route::delete('/recycle-bin/{id}', [RecycleBinController::class, 'destroy']); + Route::get('/recycle-bin/{id}/restore', [RecycleBinController::class, 'showRestore']); + Route::post('/recycle-bin/{id}/restore', [RecycleBinController::class, 'restore']); // Audit Log - Route::get('/audit', 'AuditLogController@index'); + Route::get('/audit', [AuditLogController::class, 'index']); // Users - Route::get('/users', 'UserController@index'); - Route::get('/users/create', 'UserController@create'); - Route::get('/users/{id}/delete', 'UserController@delete'); - Route::patch('/users/{id}/switch-books-view', 'UserController@switchBooksView'); - Route::patch('/users/{id}/switch-shelves-view', 'UserController@switchShelvesView'); - Route::patch('/users/{id}/switch-shelf-view', 'UserController@switchShelfView'); - Route::patch('/users/{id}/change-sort/{type}', 'UserController@changeSort'); - Route::patch('/users/{id}/update-expansion-preference/{key}', 'UserController@updateExpansionPreference'); - Route::patch('/users/toggle-dark-mode', 'UserController@toggleDarkMode'); - Route::post('/users/create', 'UserController@store'); - Route::get('/users/{id}', 'UserController@edit'); - Route::put('/users/{id}', 'UserController@update'); - Route::delete('/users/{id}', 'UserController@destroy'); + Route::get('/users', [UserController::class, 'index']); + Route::get('/users/create', [UserController::class, 'create']); + Route::get('/users/{id}/delete', [UserController::class, 'delete']); + Route::patch('/users/{id}/switch-books-view', [UserController::class, 'switchBooksView']); + Route::patch('/users/{id}/switch-shelves-view', [UserController::class, 'switchShelvesView']); + Route::patch('/users/{id}/switch-shelf-view', [UserController::class, 'switchShelfView']); + Route::patch('/users/{id}/change-sort/{type}', [UserController::class, 'changeSort']); + Route::patch('/users/{id}/update-expansion-preference/{key}', [UserController::class, 'updateExpansionPreference']); + Route::patch('/users/toggle-dark-mode', [UserController::class, 'toggleDarkMode']); + Route::post('/users/create', [UserController::class, 'store']); + Route::get('/users/{id}', [UserController::class, 'edit']); + Route::put('/users/{id}', [UserController::class, 'update']); + Route::delete('/users/{id}', [UserController::class, 'destroy']); // User API Tokens - Route::get('/users/{userId}/create-api-token', 'UserApiTokenController@create'); - Route::post('/users/{userId}/create-api-token', 'UserApiTokenController@store'); - Route::get('/users/{userId}/api-tokens/{tokenId}', 'UserApiTokenController@edit'); - Route::put('/users/{userId}/api-tokens/{tokenId}', 'UserApiTokenController@update'); - Route::get('/users/{userId}/api-tokens/{tokenId}/delete', 'UserApiTokenController@delete'); - Route::delete('/users/{userId}/api-tokens/{tokenId}', 'UserApiTokenController@destroy'); + Route::get('/users/{userId}/create-api-token', [UserApiTokenController::class, 'create']); + Route::post('/users/{userId}/create-api-token', [UserApiTokenController::class, 'store']); + Route::get('/users/{userId}/api-tokens/{tokenId}', [UserApiTokenController::class, 'edit']); + Route::put('/users/{userId}/api-tokens/{tokenId}', [UserApiTokenController::class, 'update']); + Route::get('/users/{userId}/api-tokens/{tokenId}/delete', [UserApiTokenController::class, 'delete']); + Route::delete('/users/{userId}/api-tokens/{tokenId}', [UserApiTokenController::class, 'destroy']); // Roles - Route::get('/roles', 'RoleController@list'); - Route::get('/roles/new', 'RoleController@create'); - Route::post('/roles/new', 'RoleController@store'); - Route::get('/roles/delete/{id}', 'RoleController@showDelete'); - Route::delete('/roles/delete/{id}', 'RoleController@delete'); - Route::get('/roles/{id}', 'RoleController@edit'); - Route::put('/roles/{id}', 'RoleController@update'); + Route::get('/roles', [RoleController::class, 'list']); + Route::get('/roles/new', [RoleController::class, 'create']); + Route::post('/roles/new', [RoleController::class, 'store']); + Route::get('/roles/delete/{id}', [RoleController::class, 'showDelete']); + Route::delete('/roles/delete/{id}', [RoleController::class, 'delete']); + Route::get('/roles/{id}', [RoleController::class, 'edit']); + Route::put('/roles/{id}', [RoleController::class, 'update']); }); }); // MFA routes -Route::group(['middleware' => 'mfa-setup'], function () { - Route::get('/mfa/setup', 'Auth\MfaController@setup'); - Route::get('/mfa/totp/generate', 'Auth\MfaTotpController@generate'); - Route::post('/mfa/totp/confirm', 'Auth\MfaTotpController@confirm'); - Route::get('/mfa/backup_codes/generate', 'Auth\MfaBackupCodesController@generate'); - Route::post('/mfa/backup_codes/confirm', 'Auth\MfaBackupCodesController@confirm'); +Route::middleware('mfa-setup')->group(function () { + Route::get('/mfa/setup', [Auth\MfaController::class, 'setup']); + Route::get('/mfa/totp/generate', [Auth\MfaTotpController::class, 'generate']); + Route::post('/mfa/totp/confirm', [Auth\MfaTotpController::class, 'confirm']); + Route::get('/mfa/backup_codes/generate', [Auth\MfaBackupCodesController::class, 'generate']); + Route::post('/mfa/backup_codes/confirm', [Auth\MfaBackupCodesController::class, 'confirm']); }); -Route::group(['middleware' => 'guest'], function () { - Route::get('/mfa/verify', 'Auth\MfaController@verify'); - Route::post('/mfa/totp/verify', 'Auth\MfaTotpController@verify'); - Route::post('/mfa/backup_codes/verify', 'Auth\MfaBackupCodesController@verify'); +Route::middleware('guest')->group(function () { + Route::get('/mfa/verify', [Auth\MfaController::class, 'verify']); + Route::post('/mfa/totp/verify', [Auth\MfaTotpController::class, 'verify']); + Route::post('/mfa/backup_codes/verify', [Auth\MfaBackupCodesController::class, 'verify']); }); -Route::delete('/mfa/{method}/remove', 'Auth\MfaController@remove')->middleware('auth'); +Route::delete('/mfa/{method}/remove', [Auth\MfaController::class, 'remove'])->middleware('auth'); // Social auth routes -Route::get('/login/service/{socialDriver}', 'Auth\SocialController@login'); -Route::get('/login/service/{socialDriver}/callback', 'Auth\SocialController@callback'); -Route::post('/login/service/{socialDriver}/detach', 'Auth\SocialController@detach')->middleware('auth'); -Route::get('/register/service/{socialDriver}', 'Auth\SocialController@register'); +Route::get('/login/service/{socialDriver}', [Auth\SocialController::class, 'login']); +Route::get('/login/service/{socialDriver}/callback', [Auth\SocialController::class, 'callback']); +Route::post('/login/service/{socialDriver}/detach', [Auth\SocialController::class, 'detach'])->middleware('auth'); +Route::get('/register/service/{socialDriver}', [Auth\SocialController::class, 'register']); // Login/Logout routes -Route::get('/login', 'Auth\LoginController@getLogin'); -Route::post('/login', 'Auth\LoginController@login'); -Route::get('/logout', 'Auth\LoginController@logout'); -Route::get('/register', 'Auth\RegisterController@getRegister'); -Route::get('/register/confirm', 'Auth\ConfirmEmailController@show'); -Route::get('/register/confirm/awaiting', 'Auth\ConfirmEmailController@showAwaiting'); -Route::post('/register/confirm/resend', 'Auth\ConfirmEmailController@resend'); -Route::get('/register/confirm/{token}', 'Auth\ConfirmEmailController@confirm'); -Route::post('/register', 'Auth\RegisterController@postRegister'); +Route::get('/login', [Auth\LoginController::class, 'getLogin']); +Route::post('/login', [Auth\LoginController::class, 'login']); +Route::get('/logout', [Auth\LoginController::class, 'logout']); +Route::get('/register', [Auth\RegisterController::class, 'getRegister']); +Route::get('/register/confirm', [Auth\ConfirmEmailController::class, 'show']); +Route::get('/register/confirm/awaiting', [Auth\ConfirmEmailController::class, 'showAwaiting']); +Route::post('/register/confirm/resend', [Auth\ConfirmEmailController::class, 'resend']); +Route::get('/register/confirm/{token}', [Auth\ConfirmEmailController::class, 'confirm']); +Route::post('/register', [Auth\RegisterController::class, 'postRegister']); // SAML routes -Route::post('/saml2/login', 'Auth\Saml2Controller@login'); -Route::get('/saml2/logout', 'Auth\Saml2Controller@logout'); -Route::get('/saml2/metadata', 'Auth\Saml2Controller@metadata'); -Route::get('/saml2/sls', 'Auth\Saml2Controller@sls'); -Route::post('/saml2/acs', 'Auth\Saml2Controller@startAcs'); -Route::get('/saml2/acs', 'Auth\Saml2Controller@processAcs'); +Route::post('/saml2/login', [Auth\Saml2Controller::class, 'login']); +Route::get('/saml2/logout', [Auth\Saml2Controller::class, 'logout']); +Route::get('/saml2/metadata', [Auth\Saml2Controller::class, 'metadata']); +Route::get('/saml2/sls', [Auth\Saml2Controller::class, 'sls']); +Route::post('/saml2/acs', [Auth\Saml2Controller::class, 'startAcs']); +Route::get('/saml2/acs', [Auth\Saml2Controller::class, 'processAcs']); // OIDC routes -Route::post('/oidc/login', 'Auth\OidcController@login'); -Route::get('/oidc/callback', 'Auth\OidcController@callback'); +Route::post('/oidc/login', [Auth\OidcController::class, 'login']); +Route::get('/oidc/callback', [Auth\OidcController::class, 'callback']); // User invitation routes -Route::get('/register/invite/{token}', 'Auth\UserInviteController@showSetPassword'); -Route::post('/register/invite/{token}', 'Auth\UserInviteController@setPassword'); +Route::get('/register/invite/{token}', [Auth\UserInviteController::class, 'showSetPassword']); +Route::post('/register/invite/{token}', [Auth\UserInviteController::class, 'setPassword']); // Password reset link request routes... -Route::get('/password/email', 'Auth\ForgotPasswordController@showLinkRequestForm'); -Route::post('/password/email', 'Auth\ForgotPasswordController@sendResetLinkEmail'); +Route::get('/password/email', [Auth\ForgotPasswordController::class, 'showLinkRequestForm']); +Route::post('/password/email', [Auth\ForgotPasswordController::class, 'sendResetLinkEmail']); // Password reset routes... -Route::get('/password/reset/{token}', 'Auth\ResetPasswordController@showResetForm'); -Route::post('/password/reset', 'Auth\ResetPasswordController@reset'); +Route::get('/password/reset/{token}', [Auth\ResetPasswordController::class, 'showResetForm']); +Route::post('/password/reset', [Auth\ResetPasswordController::class, 'reset']); -Route::fallback('HomeController@notFound')->name('fallback'); +Route::fallback([HomeController::class, 'notFound'])->name('fallback'); diff --git a/storage/framework/.gitignore b/storage/framework/.gitignore index 953edb7a9..05c4471f2 100755 --- a/storage/framework/.gitignore +++ b/storage/framework/.gitignore @@ -1,7 +1,9 @@ -config.php -routes.php compiled.php -services.json -events.scanned.php -routes.scanned.php +config.php down +events.scanned.php +maintenance.php +routes.php +routes.scanned.php +schedule-* +services.json diff --git a/tests/AuditLogTest.php b/tests/AuditLogTest.php index 8d13670ca..f909cd79a 100644 --- a/tests/AuditLogTest.php +++ b/tests/AuditLogTest.php @@ -17,7 +17,7 @@ class AuditLogTest extends TestCase /** @var ActivityService */ protected $activityService; - public function setUp(): void + protected function setUp(): void { parent::setUp(); $this->activityService = app(ActivityService::class); diff --git a/tests/Auth/AuthTest.php b/tests/Auth/AuthTest.php index 79f00bed0..66ab09d3c 100644 --- a/tests/Auth/AuthTest.php +++ b/tests/Auth/AuthTest.php @@ -44,7 +44,7 @@ class AuthTest extends TestCase { // Set settings and get user instance $this->setSettings(['registration-enabled' => 'true']); - $user = factory(User::class)->make(); + $user = User::factory()->make(); // Test form and ensure user is created $this->get('/register') @@ -102,7 +102,7 @@ class AuthTest extends TestCase // Set settings and get user instance $this->setSettings(['registration-enabled' => 'true', 'registration-confirmation' => 'true']); - $user = factory(User::class)->make(); + $user = User::factory()->make(); // Go through registration process $resp = $this->post('/register', $user->only('name', 'email', 'password')); @@ -140,7 +140,7 @@ class AuthTest extends TestCase public function test_restricted_registration() { $this->setSettings(['registration-enabled' => 'true', 'registration-confirmation' => 'true', 'registration-restrict' => 'example.com']); - $user = factory(User::class)->make(); + $user = User::factory()->make(); // Go through registration process $this->post('/register', $user->only('name', 'email', 'password')) @@ -166,7 +166,7 @@ class AuthTest extends TestCase public function test_restricted_registration_with_confirmation_disabled() { $this->setSettings(['registration-enabled' => 'true', 'registration-confirmation' => 'false', 'registration-restrict' => 'example.com']); - $user = factory(User::class)->make(); + $user = User::factory()->make(); // Go through registration process $this->post('/register', $user->only('name', 'email', 'password')) diff --git a/tests/Auth/LdapTest.php b/tests/Auth/LdapTest.php index 9e0729a8e..d00e8cf15 100644 --- a/tests/Auth/LdapTest.php +++ b/tests/Auth/LdapTest.php @@ -20,7 +20,7 @@ class LdapTest extends TestCase protected $mockUser; protected $resourceId = 'resource-test'; - public function setUp(): void + protected function setUp(): void { parent::setUp(); if (!defined('LDAP_OPT_REFERRALS')) { @@ -42,7 +42,7 @@ class LdapTest extends TestCase ]); $this->mockLdap = \Mockery::mock(Ldap::class); $this->app[Ldap::class] = $this->mockLdap; - $this->mockUser = factory(User::class)->make(); + $this->mockUser = User::factory()->make(); } protected function runFailedAuthLogin() @@ -264,9 +264,9 @@ class LdapTest extends TestCase public function test_login_maps_roles_and_retains_existing_roles() { - $roleToReceive = factory(Role::class)->create(['display_name' => 'LdapTester']); - $roleToReceive2 = factory(Role::class)->create(['display_name' => 'LdapTester Second']); - $existingRole = factory(Role::class)->create(['display_name' => 'ldaptester-existing']); + $roleToReceive = Role::factory()->create(['display_name' => 'LdapTester']); + $roleToReceive2 = Role::factory()->create(['display_name' => 'LdapTester Second']); + $existingRole = Role::factory()->create(['display_name' => 'ldaptester-existing']); $this->mockUser->forceFill(['external_auth_id' => $this->mockUser->name])->save(); $this->mockUser->attachRole($existingRole); @@ -310,8 +310,8 @@ class LdapTest extends TestCase public function test_login_maps_roles_and_removes_old_roles_if_set() { - $roleToReceive = factory(Role::class)->create(['display_name' => 'LdapTester']); - $existingRole = factory(Role::class)->create(['display_name' => 'ldaptester-existing']); + $roleToReceive = Role::factory()->create(['display_name' => 'LdapTester']); + $existingRole = Role::factory()->create(['display_name' => 'ldaptester-existing']); $this->mockUser->forceFill(['external_auth_id' => $this->mockUser->name])->save(); $this->mockUser->attachRole($existingRole); @@ -350,15 +350,15 @@ class LdapTest extends TestCase public function test_external_auth_id_visible_in_roles_page_when_ldap_active() { - $role = factory(Role::class)->create(['display_name' => 'ldaptester', 'external_auth_id' => 'ex-auth-a, test-second-param']); + $role = Role::factory()->create(['display_name' => 'ldaptester', 'external_auth_id' => 'ex-auth-a, test-second-param']); $this->asAdmin()->get('/settings/roles/' . $role->id) ->assertSee('ex-auth-a'); } public function test_login_maps_roles_using_external_auth_ids_if_set() { - $roleToReceive = factory(Role::class)->create(['display_name' => 'ldaptester', 'external_auth_id' => 'test-second-param, ex-auth-a']); - $roleToNotReceive = factory(Role::class)->create(['display_name' => 'ex-auth-a', 'external_auth_id' => 'test-second-param']); + $roleToReceive = Role::factory()->create(['display_name' => 'ldaptester', 'external_auth_id' => 'test-second-param, ex-auth-a']); + $roleToNotReceive = Role::factory()->create(['display_name' => 'ex-auth-a', 'external_auth_id' => 'test-second-param']); app('config')->set([ 'services.ldap.user_to_groups' => true, @@ -395,8 +395,8 @@ class LdapTest extends TestCase public function test_login_group_mapping_does_not_conflict_with_default_role() { - $roleToReceive = factory(Role::class)->create(['display_name' => 'LdapTester']); - $roleToReceive2 = factory(Role::class)->create(['display_name' => 'LdapTester Second']); + $roleToReceive = Role::factory()->create(['display_name' => 'LdapTester']); + $roleToReceive2 = Role::factory()->create(['display_name' => 'LdapTester Second']); $this->mockUser->forceFill(['external_auth_id' => $this->mockUser->name])->save(); setting()->put('registration-role', $roleToReceive->id); @@ -641,8 +641,8 @@ class LdapTest extends TestCase public function test_login_with_email_confirmation_required_maps_groups_but_shows_confirmation_screen() { - $roleToReceive = factory(Role::class)->create(['display_name' => 'LdapTester']); - $user = factory(User::class)->make(); + $roleToReceive = Role::factory()->create(['display_name' => 'LdapTester']); + $user = User::factory()->make(); setting()->put('registration-confirmation', 'true'); app('config')->set([ diff --git a/tests/Auth/OidcTest.php b/tests/Auth/OidcTest.php index 6c806aa8e..e7665a679 100644 --- a/tests/Auth/OidcTest.php +++ b/tests/Auth/OidcTest.php @@ -16,7 +16,7 @@ class OidcTest extends TestCase protected $keyFilePath; protected $keyFile; - public function setUp(): void + protected function setUp(): void { parent::setUp(); // Set default config for OpenID Connect @@ -41,7 +41,7 @@ class OidcTest extends TestCase ]); } - public function tearDown(): void + protected function tearDown(): void { parent::tearDown(); if (file_exists($this->keyFilePath)) { diff --git a/tests/Auth/Saml2Test.php b/tests/Auth/Saml2Test.php index c534b2d78..aac2710a8 100644 --- a/tests/Auth/Saml2Test.php +++ b/tests/Auth/Saml2Test.php @@ -8,7 +8,7 @@ use Tests\TestCase; class Saml2Test extends TestCase { - public function setUp(): void + protected function setUp(): void { parent::setUp(); // Set default config for SAML2 @@ -119,7 +119,7 @@ class Saml2Test extends TestCase 'saml2.remove_from_groups' => false, ]); - $memberRole = factory(Role::class)->create(['external_auth_id' => 'member']); + $memberRole = Role::factory()->create(['external_auth_id' => 'member']); $adminRole = Role::getSystemRole('admin'); $this->followingRedirects()->post('/saml2/acs', ['SAMLResponse' => $this->acsPostData]); @@ -141,7 +141,7 @@ class Saml2Test extends TestCase $acsPost = $this->followingRedirects()->post('/saml2/acs', ['SAMLResponse' => $this->acsPostData]); $user = User::query()->where('external_auth_id', '=', 'user')->first(); - $randomRole = factory(Role::class)->create(['external_auth_id' => 'random']); + $randomRole = Role::factory()->create(['external_auth_id' => 'random']); $user->attachRole($randomRole); $this->assertContains($randomRole->id, $user->roles()->pluck('id')); @@ -295,7 +295,7 @@ class Saml2Test extends TestCase 'saml2.remove_from_groups' => false, ]); - $memberRole = factory(Role::class)->create(['external_auth_id' => 'member']); + $memberRole = Role::factory()->create(['external_auth_id' => 'member']); $adminRole = Role::getSystemRole('admin'); $acsPost = $this->followingRedirects()->post('/saml2/acs', ['SAMLResponse' => $this->acsPostData]); diff --git a/tests/Auth/SocialAuthTest.php b/tests/Auth/SocialAuthTest.php index f70263dd2..90d7e37aa 100644 --- a/tests/Auth/SocialAuthTest.php +++ b/tests/Auth/SocialAuthTest.php @@ -15,7 +15,7 @@ class SocialAuthTest extends TestCase { public function test_social_registration() { - $user = factory(User::class)->make(); + $user = User::factory()->make(); $this->setSettings(['registration-enabled' => 'true']); config(['GOOGLE_APP_ID' => 'abc123', 'GOOGLE_APP_SECRET' => '123abc', 'APP_URL' => 'http://localhost']); @@ -118,7 +118,7 @@ class SocialAuthTest extends TestCase 'APP_URL' => 'http://localhost', ]); - $user = factory(User::class)->make(); + $user = User::factory()->make(); $mockSocialite = $this->mock(Factory::class); $mockSocialDriver = Mockery::mock(Provider::class); $mockSocialUser = Mockery::mock(\Laravel\Socialite\Contracts\User::class); @@ -156,7 +156,7 @@ class SocialAuthTest extends TestCase 'APP_URL' => 'http://localhost', 'services.google.auto_register' => true, 'services.google.auto_confirm' => true, ]); - $user = factory(User::class)->make(); + $user = User::factory()->make(); $mockSocialite = $this->mock(Factory::class); $mockSocialDriver = Mockery::mock(Provider::class); $mockSocialUser = Mockery::mock(\Laravel\Socialite\Contracts\User::class); @@ -188,7 +188,7 @@ class SocialAuthTest extends TestCase public function test_social_registration_with_no_name_uses_email_as_name() { - $user = factory(User::class)->make(['email' => 'nonameuser@example.com']); + $user = User::factory()->make(['email' => 'nonameuser@example.com']); $this->setSettings(['registration-enabled' => 'true']); config(['GITHUB_APP_ID' => 'abc123', 'GITHUB_APP_SECRET' => '123abc', 'APP_URL' => 'http://localhost']); diff --git a/tests/Entity/BookShelfTest.php b/tests/Entity/BookShelfTest.php index afd6a1a06..fcbc17ea9 100644 --- a/tests/Entity/BookShelfTest.php +++ b/tests/Entity/BookShelfTest.php @@ -37,7 +37,7 @@ class BookShelfTest extends TestCase public function test_shelves_shows_in_header_if_have_any_shelve_view_permission() { - $user = factory(User::class)->create(); + $user = User::factory()->create(); $this->giveUserPermissions($user, ['image-create-all']); $shelf = Bookshelf::first(); $userRole = $user->roles()->first(); diff --git a/tests/Entity/BookTest.php b/tests/Entity/BookTest.php index 53ee6faf9..2894fbb98 100644 --- a/tests/Entity/BookTest.php +++ b/tests/Entity/BookTest.php @@ -9,7 +9,7 @@ class BookTest extends TestCase { public function test_create() { - $book = factory(Book::class)->make([ + $book = Book::factory()->make([ 'name' => 'My First Book', ]); @@ -29,7 +29,7 @@ class BookTest extends TestCase public function test_create_uses_different_slugs_when_name_reused() { - $book = factory(Book::class)->make([ + $book = Book::factory()->make([ 'name' => 'My First Book', ]); diff --git a/tests/Entity/ChapterTest.php b/tests/Entity/ChapterTest.php index ea29ece5d..9868dc030 100644 --- a/tests/Entity/ChapterTest.php +++ b/tests/Entity/ChapterTest.php @@ -13,7 +13,7 @@ class ChapterTest extends TestCase /** @var Book $book */ $book = Book::query()->first(); - $chapter = factory(Chapter::class)->make([ + $chapter = Chapter::factory()->make([ 'name' => 'My First Chapter', ]); diff --git a/tests/Entity/CommentSettingTest.php b/tests/Entity/CommentSettingTest.php index d8caa7358..23607f5a7 100644 --- a/tests/Entity/CommentSettingTest.php +++ b/tests/Entity/CommentSettingTest.php @@ -9,7 +9,7 @@ class CommentSettingTest extends TestCase { protected $page; - public function setUp(): void + protected function setUp(): void { parent::setUp(); $this->page = Page::query()->first(); diff --git a/tests/Entity/CommentTest.php b/tests/Entity/CommentTest.php index b613f80a1..1e8ecbcac 100644 --- a/tests/Entity/CommentTest.php +++ b/tests/Entity/CommentTest.php @@ -13,7 +13,7 @@ class CommentTest extends TestCase $this->asAdmin(); $page = Page::first(); - $comment = factory(Comment::class)->make(['parent_id' => 2]); + $comment = Comment::factory()->make(['parent_id' => 2]); $resp = $this->postJson("/comment/$page->id", $comment->getAttributes()); $resp->assertStatus(200); @@ -36,7 +36,7 @@ class CommentTest extends TestCase $this->asAdmin(); $page = Page::first(); - $comment = factory(Comment::class)->make(); + $comment = Comment::factory()->make(); $this->postJson("/comment/$page->id", $comment->getAttributes()); $comment = $page->comments()->first(); @@ -60,7 +60,7 @@ class CommentTest extends TestCase $this->asAdmin(); $page = Page::first(); - $comment = factory(Comment::class)->make(); + $comment = Comment::factory()->make(); $this->postJson("/comment/$page->id", $comment->getAttributes()); $comment = $page->comments()->first(); diff --git a/tests/Entity/PageDraftTest.php b/tests/Entity/PageDraftTest.php index 4fb7d7ab6..9e2ceff51 100644 --- a/tests/Entity/PageDraftTest.php +++ b/tests/Entity/PageDraftTest.php @@ -20,7 +20,7 @@ class PageDraftTest extends TestCase */ protected $pageRepo; - public function setUp(): void + protected function setUp(): void { parent::setUp(); $this->page = Page::query()->first(); diff --git a/tests/Entity/PageEditorTest.php b/tests/Entity/PageEditorTest.php index 9b0a8f188..652bc1336 100644 --- a/tests/Entity/PageEditorTest.php +++ b/tests/Entity/PageEditorTest.php @@ -11,7 +11,7 @@ class PageEditorTest extends TestCase /** @var Page */ protected $page; - public function setUp(): void + protected function setUp(): void { parent::setUp(); $this->page = Page::query()->first(); diff --git a/tests/Entity/PageTest.php b/tests/Entity/PageTest.php index 313fc77f0..32459a84a 100644 --- a/tests/Entity/PageTest.php +++ b/tests/Entity/PageTest.php @@ -14,7 +14,7 @@ class PageTest extends TestCase { /** @var Chapter $chapter */ $chapter = Chapter::query()->first(); - $page = factory(Page::class)->make([ + $page = Page::factory()->make([ 'name' => 'My First Page', ]); diff --git a/tests/Entity/SortTest.php b/tests/Entity/SortTest.php index 5cfc5c3c5..89279bfcf 100644 --- a/tests/Entity/SortTest.php +++ b/tests/Entity/SortTest.php @@ -12,7 +12,7 @@ class SortTest extends TestCase { protected $book; - public function setUp(): void + protected function setUp(): void { parent::setUp(); $this->book = Book::first(); diff --git a/tests/Entity/TagTest.php b/tests/Entity/TagTest.php index 74da37f4a..9b3fb1532 100644 --- a/tests/Entity/TagTest.php +++ b/tests/Entity/TagTest.php @@ -19,7 +19,7 @@ class TagTest extends TestCase $entity = $class::first(); if (is_null($tags)) { - $tags = factory(Tag::class, $this->defaultTagCount)->make(); + $tags = Tag::factory()->count($this->defaultTagCount)->make(); } $entity->tags()->saveMany($tags); @@ -31,63 +31,63 @@ class TagTest extends TestCase { // Create some tags with similar names to test with $attrs = collect(); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'country'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'color'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'city'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'county'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'planet'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'plans'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'country'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'color'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'city'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'county'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'planet'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'plans'])); $page = $this->getEntityWithTags(Page::class, $attrs->all()); - $this->asAdmin()->get('/ajax/tags/suggest/names?search=dog')->assertExactJson([]); - $this->get('/ajax/tags/suggest/names?search=co')->assertExactJson(['color', 'country', 'county']); - $this->get('/ajax/tags/suggest/names?search=cou')->assertExactJson(['country', 'county']); - $this->get('/ajax/tags/suggest/names?search=pla')->assertExactJson(['planet', 'plans']); + $this->asAdmin()->get('/ajax/tags/suggest/names?search=dog')->assertSimilarJson([]); + $this->get('/ajax/tags/suggest/names?search=co')->assertSimilarJson(['color', 'country', 'county']); + $this->get('/ajax/tags/suggest/names?search=cou')->assertSimilarJson(['country', 'county']); + $this->get('/ajax/tags/suggest/names?search=pla')->assertSimilarJson(['planet', 'plans']); } public function test_tag_value_suggestions() { // Create some tags with similar values to test with $attrs = collect(); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'country', 'value' => 'cats'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'color', 'value' => 'cattery'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'city', 'value' => 'castle'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'county', 'value' => 'dog'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'planet', 'value' => 'catapult'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'plans', 'value' => 'dodgy'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'country', 'value' => 'cats'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'color', 'value' => 'cattery'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'city', 'value' => 'castle'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'county', 'value' => 'dog'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'planet', 'value' => 'catapult'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'plans', 'value' => 'dodgy'])); $page = $this->getEntityWithTags(Page::class, $attrs->all()); - $this->asAdmin()->get('/ajax/tags/suggest/values?search=ora')->assertExactJson([]); - $this->get('/ajax/tags/suggest/values?search=cat')->assertExactJson(['cats', 'cattery', 'catapult']); - $this->get('/ajax/tags/suggest/values?search=do')->assertExactJson(['dog', 'dodgy']); - $this->get('/ajax/tags/suggest/values?search=cas')->assertExactJson(['castle']); + $this->asAdmin()->get('/ajax/tags/suggest/values?search=ora')->assertSimilarJson([]); + $this->get('/ajax/tags/suggest/values?search=cat')->assertSimilarJson(['cats', 'cattery', 'catapult']); + $this->get('/ajax/tags/suggest/values?search=do')->assertSimilarJson(['dog', 'dodgy']); + $this->get('/ajax/tags/suggest/values?search=cas')->assertSimilarJson(['castle']); } public function test_entity_permissions_effect_tag_suggestions() { // Create some tags with similar names to test with and save to a page $attrs = collect(); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'country'])); - $attrs = $attrs->merge(factory(Tag::class, 5)->make(['name' => 'color'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'country'])); + $attrs = $attrs->merge(Tag::factory()->count(5)->make(['name' => 'color'])); $page = $this->getEntityWithTags(Page::class, $attrs->all()); - $this->asAdmin()->get('/ajax/tags/suggest/names?search=co')->assertExactJson(['color', 'country']); - $this->asEditor()->get('/ajax/tags/suggest/names?search=co')->assertExactJson(['color', 'country']); + $this->asAdmin()->get('/ajax/tags/suggest/names?search=co')->assertSimilarJson(['color', 'country']); + $this->asEditor()->get('/ajax/tags/suggest/names?search=co')->assertSimilarJson(['color', 'country']); // Set restricted permission the page $page->restricted = true; $page->save(); $page->rebuildPermissions(); - $this->asAdmin()->get('/ajax/tags/suggest/names?search=co')->assertExactJson(['color', 'country']); - $this->asEditor()->get('/ajax/tags/suggest/names?search=co')->assertExactJson([]); + $this->asAdmin()->get('/ajax/tags/suggest/names?search=co')->assertSimilarJson(['color', 'country']); + $this->asEditor()->get('/ajax/tags/suggest/names?search=co')->assertSimilarJson([]); } public function test_tags_shown_on_search_listing() { $tags = [ - factory(Tag::class)->make(['name' => 'category', 'value' => 'buckets']), - factory(Tag::class)->make(['name' => 'color', 'value' => 'red']), + Tag::factory()->make(['name' => 'category', 'value' => 'buckets']), + Tag::factory()->make(['name' => 'color', 'value' => 'red']), ]; $page = $this->getEntityWithTags(Page::class, $tags); diff --git a/tests/HomepageTest.php b/tests/HomepageTest.php index e27b78774..dc1b22779 100644 --- a/tests/HomepageTest.php +++ b/tests/HomepageTest.php @@ -167,7 +167,7 @@ class HomepageTest extends TestCase public function test_new_users_dont_have_any_recently_viewed() { - $user = factory(User::class)->create(); + $user = User::factory()->create(); $viewRole = Role::getRole('Viewer'); $user->attachRole($viewRole); diff --git a/tests/LanguageTest.php b/tests/LanguageTest.php index a9070248e..ef44af0ee 100644 --- a/tests/LanguageTest.php +++ b/tests/LanguageTest.php @@ -9,7 +9,7 @@ class LanguageTest extends TestCase /** * LanguageTest constructor. */ - public function setUp(): void + protected function setUp(): void { parent::setUp(); $this->langs = array_diff(scandir(resource_path('lang')), ['..', '.']); diff --git a/tests/Permissions/EntityPermissionsTest.php b/tests/Permissions/EntityPermissionsTest.php index bb011cfc6..96d4792b9 100644 --- a/tests/Permissions/EntityPermissionsTest.php +++ b/tests/Permissions/EntityPermissionsTest.php @@ -23,7 +23,7 @@ class EntityPermissionsTest extends TestCase */ protected $viewer; - public function setUp(): void + protected function setUp(): void { parent::setUp(); $this->user = $this->getEditor(); diff --git a/tests/Permissions/RolesTest.php b/tests/Permissions/RolesTest.php index 3178bd8ce..c880bdd00 100644 --- a/tests/Permissions/RolesTest.php +++ b/tests/Permissions/RolesTest.php @@ -19,7 +19,7 @@ class RolesTest extends TestCase { protected $user; - public function setUp(): void + protected function setUp(): void { parent::setUp(); $this->user = $this->getViewer(); @@ -769,7 +769,7 @@ class RolesTest extends TestCase $this->giveUserPermissions($this->user, ['image-update-all']); /** @var Page $page */ $page = Page::query()->first(); - $image = factory(Image::class)->create([ + $image = Image::factory()->create([ 'uploaded_to' => $page->id, 'created_by' => $this->user->id, 'updated_by' => $this->user->id, @@ -789,7 +789,7 @@ class RolesTest extends TestCase $admin = $this->getAdmin(); /** @var Page $page */ $page = Page::query()->first(); - $image = factory(Image::class)->create(['uploaded_to' => $page->id, 'created_by' => $admin->id, 'updated_by' => $admin->id]); + $image = Image::factory()->create(['uploaded_to' => $page->id, 'created_by' => $admin->id, 'updated_by' => $admin->id]); $this->actingAs($this->user)->json('delete', '/images/' . $image->id)->assertStatus(403); @@ -825,14 +825,14 @@ class RolesTest extends TestCase { $admin = $this->getAdmin(); // Book links - $book = factory(Book::class)->create(['created_by' => $admin->id, 'updated_by' => $admin->id]); + $book = Book::factory()->create(['created_by' => $admin->id, 'updated_by' => $admin->id]); $this->regenEntityPermissions($book); $this->actingAs($this->getViewer())->get($book->getUrl()) ->assertDontSee('Create a new page') ->assertDontSee('Add a chapter'); // Chapter links - $chapter = factory(Chapter::class)->create(['created_by' => $admin->id, 'updated_by' => $admin->id, 'book_id' => $book->id]); + $chapter = Chapter::factory()->create(['created_by' => $admin->id, 'updated_by' => $admin->id, 'book_id' => $book->id]); $this->regenEntityPermissions($chapter); $this->actingAs($this->getViewer())->get($chapter->getUrl()) ->assertDontSee('Create a new page') @@ -926,14 +926,14 @@ class RolesTest extends TestCase private function addComment(Page $page): TestResponse { - $comment = factory(Comment::class)->make(); + $comment = Comment::factory()->make(); return $this->postJson("/comment/$page->id", $comment->only('text', 'html')); } private function updateComment(Comment $comment): TestResponse { - $commentData = factory(Comment::class)->make(); + $commentData = Comment::factory()->make(); return $this->putJson("/comment/{$comment->id}", $commentData->only('text', 'html')); } diff --git a/tests/SharedTestHelpers.php b/tests/SharedTestHelpers.php index d96fcb710..cbf49bf71 100644 --- a/tests/SharedTestHelpers.php +++ b/tests/SharedTestHelpers.php @@ -210,7 +210,7 @@ trait SharedTestHelpers protected function createNewRole(array $permissions = []): Role { $permissionRepo = app(PermissionsRepo::class); - $roleData = factory(Role::class)->make()->toArray(); + $roleData = Role::factory()->make()->toArray(); $roleData['permissions'] = array_flip($permissions); return $permissionRepo->saveNewRole($roleData); @@ -228,9 +228,9 @@ trait SharedTestHelpers } $userAttrs = ['created_by' => $creatorUser->id, 'owned_by' => $creatorUser->id, 'updated_by' => $updaterUser->id]; - $book = factory(Book::class)->create($userAttrs); - $chapter = factory(Chapter::class)->create(array_merge(['book_id' => $book->id], $userAttrs)); - $page = factory(Page::class)->create(array_merge(['book_id' => $book->id, 'chapter_id' => $chapter->id], $userAttrs)); + $book = Book::factory()->create($userAttrs); + $chapter = Chapter::factory()->create(array_merge(['book_id' => $book->id], $userAttrs)); + $page = Page::factory()->create(array_merge(['book_id' => $book->id, 'chapter_id' => $chapter->id], $userAttrs)); $restrictionService = $this->app[PermissionService::class]; $restrictionService->buildJointPermissionsForEntity($book); diff --git a/tests/ThemeTest.php b/tests/ThemeTest.php index 2cab765ae..9aa7873b0 100644 --- a/tests/ThemeTest.php +++ b/tests/ThemeTest.php @@ -150,7 +150,7 @@ class ThemeTest extends TestCase Theme::listen(ThemeEvents::AUTH_REGISTER, $callback); $this->setSettings(['registration-enabled' => 'true']); - $user = factory(User::class)->make(); + $user = User::factory()->make(); $this->post('/register', ['email' => $user->email, 'name' => $user->name, 'password' => 'password']); $this->assertCount(2, $args); diff --git a/tests/Uploads/AvatarTest.php b/tests/Uploads/AvatarTest.php index cf568d07c..d10b5cfc6 100644 --- a/tests/Uploads/AvatarTest.php +++ b/tests/Uploads/AvatarTest.php @@ -42,7 +42,7 @@ class AvatarTest extends TestCase config()->set([ 'services.disable_services' => false, ]); - $user = factory(User::class)->make(); + $user = User::factory()->make(); $this->assertImageFetchFrom('https://www.gravatar.com/avatar/' . md5(strtolower($user->email)) . '?s=500&d=identicon'); $user = $this->createUserRequest($user); @@ -60,7 +60,7 @@ class AvatarTest extends TestCase 'services.avatar_url' => 'https://example.com/${email}/${hash}/${size}', ]); - $user = factory(User::class)->make(); + $user = User::factory()->make(); $url = 'https://example.com/' . urlencode(strtolower($user->email)) . '/' . md5(strtolower($user->email)) . '/500'; $this->assertImageFetchFrom($url); @@ -74,7 +74,7 @@ class AvatarTest extends TestCase 'services.disable_services' => true, ]); - $user = factory(User::class)->make(); + $user = User::factory()->make(); $http = $this->mock(HttpFetcher::class); $http->shouldNotReceive('fetch'); @@ -93,7 +93,7 @@ class AvatarTest extends TestCase $logger = $this->withTestLogger(); - $user = factory(User::class)->make(); + $user = User::factory()->make(); $this->createUserRequest($user); $this->assertTrue($logger->hasError('Failed to save user avatar image')); } diff --git a/tests/User/UserManagementTest.php b/tests/User/UserManagementTest.php index ed2fb5f04..5a36b85df 100644 --- a/tests/User/UserManagementTest.php +++ b/tests/User/UserManagementTest.php @@ -15,7 +15,7 @@ class UserManagementTest extends TestCase public function test_user_creation() { /** @var User $user */ - $user = factory(User::class)->make(); + $user = User::factory()->make(); $adminRole = Role::getRole('admin'); $resp = $this->asAdmin()->get('/settings/users'); diff --git a/tests/User/UserProfileTest.php b/tests/User/UserProfileTest.php index 3942efa8e..c3888f8c5 100644 --- a/tests/User/UserProfileTest.php +++ b/tests/User/UserProfileTest.php @@ -14,7 +14,7 @@ class UserProfileTest extends TestCase */ protected $user; - public function setUp(): void + protected function setUp(): void { parent::setUp(); $this->user = User::all()->last(); @@ -42,7 +42,7 @@ class UserProfileTest extends TestCase public function test_profile_page_shows_created_content_counts() { - $newUser = factory(User::class)->create(); + $newUser = User::factory()->create(); $this->asAdmin()->get('/user/' . $newUser->slug) ->assertSee($newUser->name) @@ -61,7 +61,7 @@ class UserProfileTest extends TestCase public function test_profile_page_shows_recent_activity() { - $newUser = factory(User::class)->create(); + $newUser = User::factory()->create(); $this->actingAs($newUser); $entities = $this->createEntityChainBelongingToUser($newUser, $newUser); Activity::addForEntity($entities['book'], ActivityType::BOOK_UPDATE); @@ -75,7 +75,7 @@ class UserProfileTest extends TestCase public function test_user_activity_has_link_leading_to_profile() { - $newUser = factory(User::class)->create(); + $newUser = User::factory()->create(); $this->actingAs($newUser); $entities = $this->createEntityChainBelongingToUser($newUser, $newUser); Activity::addForEntity($entities['book'], ActivityType::BOOK_UPDATE);