colin
/
mlir-hlo
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Min and InfinityMin of boolean should be false. 

PiperOrigin-RevId: 370759584
This commit is contained in:
Prakalp Srivastava 2021-04-27 14:09:46 -07:00 committed by TensorFlow MLIR Team
parent b2a23bf269
commit 565856acd1
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/utils/hlo_utils.cc
View File

@ -100,10 +100,11 @@ static APFloat GetScalarLimitOfFloatType(FloatType float_ty,
static APInt GetScalarLimitOfIntegerType(IntegerType integer_ty, static APInt GetScalarLimitOfIntegerType(IntegerType integer_ty,
ScalarLimit limit) { ScalarLimit limit) {
unsigned width = integer_ty.getWidth(); unsigned width = integer_ty.getWidth();
bool is_bool = (width == 1);
switch (limit) { switch (limit) {
case kLowest: case kLowest:
case kInfinityLowest: case kInfinityLowest:
if (integer_ty.isUnsigned()) { if (integer_ty.isUnsigned() || is_bool) {
return APInt::getMinValue(width); return APInt::getMinValue(width);
} else { } else {
return APInt::getSignedMinValue(width); return APInt::getSignedMinValue(width);
@ -111,7 +112,7 @@ static APInt GetScalarLimitOfIntegerType(IntegerType integer_ty,
case kMax: case kMax:
case kInfinityMax: case kInfinityMax:
if (integer_ty.isUnsigned()) { if (integer_ty.isUnsigned() || is_bool) {
return APInt::getMaxValue(width); return APInt::getMaxValue(width);
} else { } else {
return APInt::getSignedMaxValue(width); return APInt::getSignedMaxValue(width);