From dd15c6cd84934d167476c77f369c64ea6bc672ce Mon Sep 17 00:00:00 2001 From: "A. Unique TensorFlower" Date: Mon, 30 Nov 2020 01:40:08 -0800 Subject: [PATCH] [MLIR][KernelGen] Generate assertion message in `transform_unranked_hlo` pass Use constant to generate the correct assertion message. This avoids confusion when lowering the max rank specialization for debugging. PiperOrigin-RevId: 344769021 --- lib/Dialect/mhlo/transforms/transform_unranked_hlo.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Dialect/mhlo/transforms/transform_unranked_hlo.cc b/lib/Dialect/mhlo/transforms/transform_unranked_hlo.cc index a47ce7b..902f203 100644 --- a/lib/Dialect/mhlo/transforms/transform_unranked_hlo.cc +++ b/lib/Dialect/mhlo/transforms/transform_unranked_hlo.cc @@ -400,7 +400,7 @@ struct ConvertUnrankedDynamicBroadcastBinaryOp rewriter.create(loc, greater_rank_lhs, lhs_rank, rhs_rank); // Generate a list of nested if/else statements to handle rank - // specializations from 1-6. + // specializations from 1 to `kMaxRankSpecialization`. scf::IfOp if_op = createIfOpForRankSpecializedBroadcastAndOp( rewriter, op, greater_rank, 1); OpBuilder if_builder = if_op.getThenBodyBuilder(rewriter.getListener()); @@ -419,13 +419,13 @@ struct ConvertUnrankedDynamicBroadcastBinaryOp else_builder = inner_if.getElseBodyBuilder(rewriter.getListener()); } // Fire an assertion if none of the rank specializations applied (one of - // the ranks was greater than 6). + // the ranks was greater than `kMaxRankSpecialization`). else_builder.create( loc, GreaterRankIsN(else_builder, op.getLoc(), greater_rank, kMaxRankSpecialization), - "Input for dynamic binary op lowering was of a rank greater than " - "6"); + "Input for dynamic binary op lowering was of a rank greater than " + + std::to_string(kMaxRankSpecialization)); // Add the rank 6 specialization to the innermost else block. createRankSpecializedBroadcastAndOp(else_builder, op, lhs, rhs, kMaxRankSpecialization);