From 8b6cf7c661ab652d730eefb2b931928326218509 Mon Sep 17 00:00:00 2001
From: "Tung D. Le" <tung@jp.ibm.com>
Date: Tue, 7 Jul 2020 14:47:54 +0900
Subject: [PATCH] Remove dangling constant op (#205)

---
 src/Builder/FrontendDialectTransformer.cpp | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/Builder/FrontendDialectTransformer.cpp b/src/Builder/FrontendDialectTransformer.cpp
index 00ab212..d7f852c 100644
--- a/src/Builder/FrontendDialectTransformer.cpp
+++ b/src/Builder/FrontendDialectTransformer.cpp
@@ -222,8 +222,12 @@ private:
 
     // Trailing optional inputs.
     if (!variadicIn)
-      for (auto i = inputs.size(); i < expectedNumOperands; i++)
+      for (auto i = inputs.size(); i < expectedNumOperands; i++) {
+        if (!none_)
+          none_ = builder_.create<mlir::ConstantOp>(
+              UnknownLoc(), builder_.getUnitAttr());
         inputs.emplace_back(none_);
+      }
 
     std::vector<mlir::Type> outputTypes;
 
@@ -482,11 +486,6 @@ private:
       }
     }
 
-    // Create a NoneTyped constant to be used for optional operation inputs
-    // which are not used.
-    none_ =
-        builder_.create<mlir::ConstantOp>(UnknownLoc(), builder_.getUnitAttr());
-
     // Import nodes in the graph.
     for (const auto &item : graph.node()) {
       ImportNode(item);