From 94391a3cdef0095d68bcb8606caa00161f0d7840 Mon Sep 17 00:00:00 2001 From: Doru Bercea Date: Wed, 22 Jan 2020 15:05:56 -0500 Subject: [PATCH] Add comment. --- src/dialect/onnx/onnx_ops.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/dialect/onnx/onnx_ops.cpp b/src/dialect/onnx/onnx_ops.cpp index 265842b..83059cd 100644 --- a/src/dialect/onnx/onnx_ops.cpp +++ b/src/dialect/onnx/onnx_ops.cpp @@ -484,6 +484,9 @@ void ONNXConvNoBiasOp::inferShapes() { if (dataShape[1] != (weightShape[1] * group)) emitError("Channel dimension mismatch."); + // Note: the value of the group attribut only impacts the way the + // computation is carried out and not the actual output size. + // First two output dimensions consist of the number of batches and the // number of kernels being applied. //