[#5607] rename aux.db to auxiliary.db

CHANGELOG.md

@@ -1,3 +1,10 @@
+## v0.23.0-rc2
+
+> **This is a prerelease intended for test and experimental purposes only!**
+
+- Small update to the earlier v0.23.0-rc that renames the new `pb_data/aux.db` to `pb_data/auxiliary.db` because it seems that on Windows `aux` is disallowed as file name ([#5607](https://github.com/pocketbase/pocketbase/issues/5607)).
+   _If you have already upgraded to v0.23.0-rc please rename manually your `pb_data/aux.db` file to `pb_data/auxiliry.db`._
+
 ## v0.23.0-rc
 
 > [!CAUTION]
@@ -27,7 +34,7 @@ There are many changes but to highlight some of the most notable ones:
 - New hooks allowing better control over the execution chain and error handling (_including wrapping an entire hook chain in a single DB transaction_).
 - Various `Record` model improvements (_support for get/set modifiers, simplfied file upload by treating the file(s) as regular field value like `record.Set("document", file)`, etc._).
 - Dedicated fields structs with safer defaults to make it easier creating/updating collections programmatically.
-- Option to mark field as Private/Hidden, disallowing regular users to read or modify it (_there is also a dedicated Record hook to hide/unhide Record fields progrommatically from a single place_).
+- Option to mark field as Private/Hidden, disallowing regular users to read or modify it (_there is also a dedicated Record hook to hide/unhide Record fields programmatically from a single place_).
 - Option to customize the default system collection fields (`id`, `email`, `password`, etc.).
 - Admins are now system `_superusers` auth records.
 - Builtin rate limiter (_supports tags, wildcards and exact routes matching_).

apis/backup_test.go

@@ -517,7 +517,7 @@ func TestBackupsDownload(t *testing.T) {
 			ExpectedContent: []string{
 				"storage/",
 				"data.db",
-				"aux.db",
+				"auxiliary.db",
 			},
 			ExpectedEvents: map[string]int{"*": 0},
 		},
@@ -534,7 +534,7 @@ func TestBackupsDownload(t *testing.T) {
 			ExpectedContent: []string{
 				"storage/",
 				"data.db",
-				"aux.db",
+				"auxiliary.db",
 			},
 			ExpectedEvents: map[string]int{"*": 0},
 		},

core/app.go

@@ -157,10 +157,10 @@ type App interface {
 	// In a transaction the ConcurrentDB() and NonconcurrentDB() refer to the same *dbx.TX instance.
 	NonconcurrentDB() dbx.Builder
 
-	// AuxDB returns the default app auxiliary db instance (pb_data/aux.db).
+	// AuxDB returns the default app auxiliary db instance (pb_data/auxiliary.db).
 	AuxDB() dbx.Builder
 
-	// AuxNonconcurrentDB returns the nonconcurrent app auxiliary db instance (pb_data/aux.db)..
+	// AuxNonconcurrentDB returns the nonconcurrent app auxiliary db instance (pb_data/auxiliary.db)..
 	//
 	// The returned db instance is limited only to a single open connection,
 	// meaning that it can process only 1 db operation at a time (other operations will be queued up).

core/base.go

@@ -481,12 +481,12 @@ func (app *BaseApp) NonconcurrentDB() dbx.Builder {
 	return app.nonconcurrentDB
 }
 
-// AuxDB returns the default app auxiliary db instance (pb_data/aux.db).
+// AuxDB returns the default app auxiliary db instance (pb_data/auxiliary.db).
 func (app *BaseApp) AuxDB() dbx.Builder {
 	return app.auxConcurrentDB
 }
 
-// AuxNonconcurrentDB returns the nonconcurrent app auxiliary db instance (pb_data/aux.db).
+// AuxNonconcurrentDB returns the nonconcurrent app auxiliary db instance (pb_data/auxiliary.db).
 //
 // The returned db instance is limited only to a single open connection,
 // meaning that it can process only 1 db operation at a time (other operations will be queued up).
@@ -1151,7 +1151,9 @@ func normalizeSQLLog(sql string) string {
 }
 
 func (app *BaseApp) initAuxDB() error {
-	dbPath := filepath.Join(app.DataDir(), "aux.db")
+	// note: renamed to "auxiliary" because "aux" is a reserved Windows filename
+	// (see https://github.com/pocketbase/pocketbase/issues/5607)
+	dbPath := filepath.Join(app.DataDir(), "auxiliary.db")
 
 	concurrentDB, err := app.config.DBConnect(dbPath)
 	if err != nil {

core/base_backup_test.go

@@ -128,9 +128,9 @@ func verifyBackupContent(app core.App, path string) error {
 		"data.db",
 		"data.db-shm",
 		"data.db-wal",
-		"aux.db",
+		"auxiliary.db",
-		"aux.db-shm",
+		"auxiliary.db-shm",
-		"aux.db-wal",
+		"auxiliary.db-wal",
 		".gitignore",
 	}