colin
/
pocketbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

added negative string number normalizations for the json field type

This commit is contained in:
Gani Georgiev 2023-10-27 22:36:16 +03:00
parent f889a3fcb3
commit 1ae570921b
3 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -27,6 +27,8 @@
) )
``` ```
- Other minor fixes and impovements (eg. added negative string number normalization support for the `json` field type)
## v0.19.1 ## v0.19.1

1
models/schema/schema_field.go
View File

@ -310,6 +310,7 @@ func (f *SchemaField) PrepareValue(value any) any {
} else if str == "null" || str == "true" || str == "false" { } else if str == "null" || str == "true" || str == "false" {
val = str val = str
} else if ((str[0] >= '0' && str[0] <= '9') || } else if ((str[0] >= '0' && str[0] <= '9') ||
str[0] == '-' ||
str[0] == '"' || str[0] == '"' ||
str[0] == '[' || str[0] == '[' ||
str[0] == '{') && str[0] == '{') &&

5
models/schema/schema_field_test.go
View File

@ -603,10 +603,15 @@ func TestSchemaFieldPrepareValue(t *testing.T) {
{schema.SchemaField{Type: schema.FieldTypeJson}, nil, "null"}, {schema.SchemaField{Type: schema.FieldTypeJson}, nil, "null"},
{schema.SchemaField{Type: schema.FieldTypeJson}, "null", "null"}, {schema.SchemaField{Type: schema.FieldTypeJson}, "null", "null"},
{schema.SchemaField{Type: schema.FieldTypeJson}, 123, "123"}, {schema.SchemaField{Type: schema.FieldTypeJson}, 123, "123"},
{schema.SchemaField{Type: schema.FieldTypeJson}, -123, "-123"},
{schema.SchemaField{Type: schema.FieldTypeJson}, "123", "123"}, {schema.SchemaField{Type: schema.FieldTypeJson}, "123", "123"},
{schema.SchemaField{Type: schema.FieldTypeJson}, "-123", "-123"},
{schema.SchemaField{Type: schema.FieldTypeJson}, 123.456, "123.456"}, {schema.SchemaField{Type: schema.FieldTypeJson}, 123.456, "123.456"},
{schema.SchemaField{Type: schema.FieldTypeJson}, -123.456, "-123.456"},
{schema.SchemaField{Type: schema.FieldTypeJson}, "123.456", "123.456"}, {schema.SchemaField{Type: schema.FieldTypeJson}, "123.456", "123.456"},
{schema.SchemaField{Type: schema.FieldTypeJson}, "-123.456", "-123.456"},
{schema.SchemaField{Type: schema.FieldTypeJson}, "123.456 abc", `"123.456 abc"`}, // invalid numeric string {schema.SchemaField{Type: schema.FieldTypeJson}, "123.456 abc", `"123.456 abc"`}, // invalid numeric string
{schema.SchemaField{Type: schema.FieldTypeJson}, "-a123", `"-a123"`},
{schema.SchemaField{Type: schema.FieldTypeJson}, true, "true"}, {schema.SchemaField{Type: schema.FieldTypeJson}, true, "true"},
{schema.SchemaField{Type: schema.FieldTypeJson}, "true", "true"}, {schema.SchemaField{Type: schema.FieldTypeJson}, "true", "true"},
{schema.SchemaField{Type: schema.FieldTypeJson}, false, "false"}, {schema.SchemaField{Type: schema.FieldTypeJson}, false, "false"},