[#4310] allow HEAD requests to the health endpoint
This commit is contained in:
		
							parent
							
								
									c32f272123
								
							
						
					
					
						commit
						388f61aed6
					
				|  | @ -1,6 +1,8 @@ | |||
| ## (WIP) v0.21.3 | ||||
| 
 | ||||
| - Disable the JS required validations for disabled OIDC providers ([#4322](https://github.com/pocketbase/pocketbase/issues/4322)). | ||||
| - Ignore the JS required validations for disabled OIDC providers ([#4322](https://github.com/pocketbase/pocketbase/issues/4322)). | ||||
| 
 | ||||
| - Allow `HEAD` requests to the `/api/health` endpoint ([#4310](https://github.com/pocketbase/pocketbase/issues/4310)). | ||||
| 
 | ||||
| 
 | ||||
| ## v0.21.2 | ||||
|  |  | |||
|  | @ -12,6 +12,7 @@ func bindHealthApi(app core.App, rg *echo.Group) { | |||
| 	api := healthApi{app: app} | ||||
| 
 | ||||
| 	subGroup := rg.Group("/health") | ||||
| 	subGroup.HEAD("", api.healthCheck) | ||||
| 	subGroup.GET("", api.healthCheck) | ||||
| } | ||||
| 
 | ||||
|  | @ -29,6 +30,10 @@ type healthCheckResponse struct { | |||
| 
 | ||||
| // healthCheck returns a 200 OK response if the server is healthy.
 | ||||
| func (api *healthApi) healthCheck(c echo.Context) error { | ||||
| 	if c.Request().Method == http.MethodHead { | ||||
| 		return c.NoContent(http.StatusOK) | ||||
| 	} | ||||
| 
 | ||||
| 	resp := new(healthCheckResponse) | ||||
| 	resp.Code = http.StatusOK | ||||
| 	resp.Message = "API is healthy." | ||||
|  |  | |||
|  | @ -12,7 +12,13 @@ func TestHealthAPI(t *testing.T) { | |||
| 
 | ||||
| 	scenarios := []tests.ApiScenario{ | ||||
| 		{ | ||||
| 			Name:           "health status returns 200", | ||||
| 			Name:           "HEAD health status", | ||||
| 			Method:         http.MethodHead, | ||||
| 			Url:            "/api/health", | ||||
| 			ExpectedStatus: 200, | ||||
| 		}, | ||||
| 		{ | ||||
| 			Name:           "GET health status", | ||||
| 			Method:         http.MethodGet, | ||||
| 			Url:            "/api/health", | ||||
| 			ExpectedStatus: 200, | ||||
|  |  | |||
		Loading…
	
		Reference in New Issue