colin
/
pocketbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

replaced LOWER with COLLATE NOCASE

This commit is contained in:
Gani Georgiev 2024-12-11 11:08:29 +02:00
parent 3ec10a9c7d
commit 7481c3f7f4
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/field_text.go
View File

@ -190,11 +190,13 @@ func (f *TextField) ValidateValue(ctx context.Context, app App, record *Record)
// this technically shouldn't be necessarily but again to // this technically shouldn't be necessarily but again to
// minimize misuse of the Pattern validator that could cause // minimize misuse of the Pattern validator that could cause
// side-effects on some platforms check for duplicates in a case-insensitive manner // side-effects on some platforms check for duplicates in a case-insensitive manner
//
// (@todo eventually may get replaced in the future with a system unique constraint to avoid races or wrapping the request in a transaction)
var exists bool var exists bool
err := app.DB(). err := app.DB().
Select("(1)"). Select("(1)").
From(record.TableName()). From(record.TableName()).
Where(dbx.NewExp("LOWER(id) = {:id}", dbx.Params{"id": strings.ToLower(newVal)})). Where(dbx.NewExp("id = {:id} COLLATE NOCASE", dbx.Params{"id": strings.ToLower(newVal)})).
Limit(1). Limit(1).
Row(&exists) Row(&exists)
if exists || (err != nil && !errors.Is(err, sql.ErrNoRows)) { if exists || (err != nil && !errors.Is(err, sql.ErrNoRows)) {