diff --git a/CHANGELOG.md b/CHANGELOG.md index 3f630edd..69537c54 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,12 @@ +## v0.10.3 + +- ! Renamed the metadata key `original_filename` to `original-filename` due to an S3 file upload error caused by the underscore character ([#1343](https://github.com/pocketbase/pocketbase/pull/1343); thanks @yuxiang-gao). + +- Fixed request verification docs api url ([#1332](https://github.com/pocketbase/pocketbase/pull/1332); thanks @JoyMajumdar2001) + +- Exclude `collectionId` and `collectionName` from the displayable relation props list ([1322](https://github.com/pocketbase/pocketbase/issues/1322); thanks @dhall2). + + ## v0.10.2 - Fixed nested multiple expands with shared path ([#586](https://github.com/pocketbase/pocketbase/issues/586#issuecomment-1357784227)). diff --git a/tools/filesystem/filesystem_test.go b/tools/filesystem/filesystem_test.go index d8b47b3d..f03f22a3 100644 --- a/tools/filesystem/filesystem_test.go +++ b/tools/filesystem/filesystem_test.go @@ -170,7 +170,7 @@ func TestFileSystemUploadMultipart(t *testing.T) { } if exists, _ := fs.Exists(fileKey); !exists { - t.Fatalf("Expected newdir/newkey.txt to exist") + t.Fatalf("Expected %q to exist", fileKey) } attrs, err := fs.Attributes(fileKey) @@ -182,6 +182,43 @@ func TestFileSystemUploadMultipart(t *testing.T) { } } +func TestFileSystemUploadFile(t *testing.T) { + dir := createTestDir(t) + defer os.RemoveAll(dir) + + fs, err := filesystem.NewLocal(dir) + if err != nil { + t.Fatal(err) + } + defer fs.Close() + + fileKey := "newdir/newkey.txt" + + file, err := filesystem.NewFileFromPath(filepath.Join(dir, "image.svg")) + if err != nil { + t.Fatalf("Failed to load test file: %v", err) + } + + file.OriginalName = "test.txt" + + uploadErr := fs.UploadFile(file, fileKey) + if uploadErr != nil { + t.Fatal(uploadErr) + } + + if exists, _ := fs.Exists(fileKey); !exists { + t.Fatalf("Expected %q to exist", fileKey) + } + + attrs, err := fs.Attributes(fileKey) + if err != nil { + t.Fatalf("Failed to fetch file attributes: %v", err) + } + if name, ok := attrs.Metadata["original-filename"]; !ok || name != file.OriginalName { + t.Fatalf("Expected original-filename to be %q, got %q", file.OriginalName, name) + } +} + func TestFileSystemUpload(t *testing.T) { dir := createTestDir(t) defer os.RemoveAll(dir) @@ -192,13 +229,15 @@ func TestFileSystemUpload(t *testing.T) { } defer fs.Close() - uploadErr := fs.Upload([]byte("demo"), "newdir/newkey.txt") + fileKey := "newdir/newkey.txt" + + uploadErr := fs.Upload([]byte("demo"), fileKey) if uploadErr != nil { t.Fatal(uploadErr) } - if exists, _ := fs.Exists("newdir/newkey.txt"); !exists { - t.Fatalf("Expected newdir/newkey.txt to exist") + if exists, _ := fs.Exists(fileKey); !exists { + t.Fatalf("Expected %s to exist", fileKey) } }