colin
/
pocketbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

defined Default* constants for the pool limits

This commit is contained in:
Gani Georgiev 2022-12-15 18:10:31 +02:00
parent b9e257d2b1
commit 8e582acbee
2 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
core/base.go
View File

@ -21,6 +21,13 @@ import (
"github.com/pocketbase/pocketbase/tools/subscriptions" "github.com/pocketbase/pocketbase/tools/subscriptions"
) )
const (
DefaultDataMaxOpenConns int = 100
DefaultDataMaxIdleConns int = 20
DefaultLogsMaxOpenConns int = 10
DefaultLogsMaxIdleConns int = 2
)
var _ App = (*BaseApp)(nil) var _ App = (*BaseApp)(nil)
// BaseApp implements core.App and defines the base PocketBase app structure. // BaseApp implements core.App and defines the base PocketBase app structure.
@ -139,10 +146,10 @@ type BaseAppConfig struct {
DataDir string DataDir string
EncryptionEnv string EncryptionEnv string
IsDebug bool IsDebug bool
DataMaxOpenConns int // default to 600 DataMaxOpenConns int // default to 500
DataMaxIdleConns int // default 20 DataMaxIdleConns int // default 20
LogsMaxOpenConns int // default to 500 LogsMaxOpenConns int // default to 100
LogsMaxIdleConns int // default to 10 LogsMaxIdleConns int // default to 5
} }
// NewBaseApp creates and returns a new BaseApp instance // NewBaseApp creates and returns a new BaseApp instance
@ -802,8 +809,8 @@ func (app *BaseApp) OnCollectionsAfterImportRequest() *hook.Hook[*CollectionsImp
// ------------------------------------------------------------------- // -------------------------------------------------------------------
func (app *BaseApp) initLogsDB() error { func (app *BaseApp) initLogsDB() error {
maxOpenConns := 500 maxOpenConns := DefaultLogsMaxOpenConns
maxIdleConns := 10 maxIdleConns := DefaultLogsMaxIdleConns
if app.logsMaxOpenConns > 0 { if app.logsMaxOpenConns > 0 {
maxOpenConns = app.logsMaxOpenConns maxOpenConns = app.logsMaxOpenConns
} }
@ -833,8 +840,8 @@ func (app *BaseApp) initLogsDB() error {
} }
func (app *BaseApp) initDataDB() error { func (app *BaseApp) initDataDB() error {
maxOpenConns := 600 maxOpenConns := DefaultDataMaxOpenConns
maxIdleConns := 20 maxIdleConns := DefaultDataMaxIdleConns
if app.dataMaxOpenConns > 0 { if app.dataMaxOpenConns > 0 {
maxOpenConns = app.dataMaxOpenConns maxOpenConns = app.dataMaxOpenConns
} }

8
pocketbase.go
View File

@ -51,10 +51,10 @@ type Config struct {
HideStartBanner bool HideStartBanner bool
// optional DB configurations // optional DB configurations
DataMaxOpenConns int // default to 600 DataMaxOpenConns int // default to core.DefaultDataMaxOpenConns
DataMaxIdleConns int // default 20 DataMaxIdleConns int // default to core.DefaultDataMaxIdleConns
LogsMaxOpenConns int // default to 500 LogsMaxOpenConns int // default to core.DefaultLogsMaxOpenConns
LogsMaxIdleConns int // default to 10 LogsMaxIdleConns int // default to core.DefaultLogsMaxIdleConns
} }
// New creates a new PocketBase instance with the default configuration. // New creates a new PocketBase instance with the default configuration.