From caf343ef9cd638568a613a4e8bcb2e49229fc27b Mon Sep 17 00:00:00 2001
From: Sven-Kristjan Kompus <63632594+svekko@users.noreply.github.com>
Date: Fri, 16 Jun 2023 14:43:05 +0300
Subject: [PATCH] [#2726] removed unnecessary Dao().TotalAdmins() call

---
 apis/middlewares.go | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/apis/middlewares.go b/apis/middlewares.go
index 3b8d808d..05e1d0ff 100644
--- a/apis/middlewares.go
+++ b/apis/middlewares.go
@@ -129,14 +129,17 @@ func RequireAdminAuth() echo.MiddlewareFunc {
 func RequireAdminAuthOnlyIfAny(app core.App) echo.MiddlewareFunc {
 	return func(next echo.HandlerFunc) echo.HandlerFunc {
 		return func(c echo.Context) error {
+			admin, _ := c.Get(ContextAdminKey).(*models.Admin)
+			if admin != nil {
+				return next(c)
+			}
+
 			totalAdmins, err := app.Dao().TotalAdmins()
 			if err != nil {
 				return NewBadRequestError("Failed to fetch admins info.", err)
 			}
 
-			admin, _ := c.Get(ContextAdminKey).(*models.Admin)
-
-			if admin != nil || totalAdmins == 0 {
+			if totalAdmins == 0 {
 				return next(c)
 			}