From e8d61e7b45e734d2c4c42d6c645d187796eec3bd Mon Sep 17 00:00:00 2001
From: Gani Georgiev <gani.georgiev@gmail.com>
Date: Sat, 4 Mar 2023 13:05:55 +0200
Subject: [PATCH] simplified rules ui

---
 .../collections/CollectionRulesTab.svelte         |  5 -----
 ui/src/components/collections/RuleField.svelte    | 15 +++------------
 2 files changed, 3 insertions(+), 17 deletions(-)

diff --git a/ui/src/components/collections/CollectionRulesTab.svelte b/ui/src/components/collections/CollectionRulesTab.svelte
index 74ece011..eb5f0a0d 100644
--- a/ui/src/components/collections/CollectionRulesTab.svelte
+++ b/ui/src/components/collections/CollectionRulesTab.svelte
@@ -77,22 +77,17 @@
 
 <RuleField label="List/Search rule" formKey="listRule" {collection} bind:rule={collection.listRule} />
 
-<hr class="m-t-sm m-b-sm" />
 <RuleField label="View rule" formKey="viewRule" {collection} bind:rule={collection.viewRule} />
 
 {#if !collection?.isView}
-    <hr class="m-t-sm m-b-sm" />
     <RuleField label="Create rule" formKey="createRule" {collection} bind:rule={collection.createRule} />
 
-    <hr class="m-t-sm m-b-sm" />
     <RuleField label="Update rule" formKey="updateRule" {collection} bind:rule={collection.updateRule} />
 
-    <hr class="m-t-sm m-b-sm" />
     <RuleField label="Delete rule" formKey="deleteRule" {collection} bind:rule={collection.deleteRule} />
 {/if}
 
 {#if collection?.isAuth}
-    <hr class="m-t-sm m-b-sm" />
     <RuleField
         label="Manage rule"
         formKey="options.manageRule"
diff --git a/ui/src/components/collections/RuleField.svelte b/ui/src/components/collections/RuleField.svelte
index 2da0ff1f..50f70949 100644
--- a/ui/src/components/collections/RuleField.svelte
+++ b/ui/src/components/collections/RuleField.svelte
@@ -53,7 +53,7 @@
     </div>
 {:else}
     <Field
-        class="form-field rule-field m-0 {required ? 'requied' : ''} {isAdminOnly ? 'disabled' : ''}"
+        class="form-field rule-field {required ? 'requied' : ''} {isAdminOnly ? 'disabled' : ''}"
         name={formKey}
         let:uniqueId
     >
@@ -93,20 +93,11 @@
             bind:value={rule}
             baseCollection={collection}
             disabled={isAdminOnly}
+            placeholder={!isAdminOnly ? "Leave empty to grant everyone access..." : ""}
         />
 
         <div class="help-block">
-            <slot {isAdminOnly}>
-                <p>
-                    {#if isAdminOnly}
-                        Only admins will be able to perform this action (
-                        <button type="button" class="link-primary" on:click={unlock}>unlock to change</button>
-                        ).
-                    {:else}
-                        Leave empty to grant everyone access.
-                    {/if}
-                </p>
-            </slot>
+            <slot {isAdminOnly} />
         </div>
     </Field>
 {/if}