colin
/
pocketbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

added httpAddr default when domain name is missing

This commit is contained in:
Gani Georgiev 2023-08-25 12:06:24 +03:00
parent c89c68a4dc
commit ef73052546
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -2,6 +2,8 @@
- (@todo docs) Simplified the `serve` command when used with a domain name. - (@todo docs) Simplified the `serve` command when used with a domain name.
- Bumped the min TLS version to 1.2 in order to improve the cert score.
- Added new `SmtpConfig.LocalName` option to specify a custom domain name (or IP address) for the initial EHLO/HELO exchange ([#3097](https://github.com/pocketbase/pocketbase/discussions/3097)). - Added new `SmtpConfig.LocalName` option to specify a custom domain name (or IP address) for the initial EHLO/HELO exchange ([#3097](https://github.com/pocketbase/pocketbase/discussions/3097)).
_This is usually required for verification purposes only by some SMTP providers, such as on-premise [Gmail SMTP-relay](https://support.google.com/a/answer/2956491)._ _This is usually required for verification purposes only by some SMTP providers, such as on-premise [Gmail SMTP-relay](https://support.google.com/a/answer/2956491)._

4
cmd/serve.go
View File

@ -29,6 +29,10 @@ func NewServeCommand(app core.App, showStartBanner bool) *cobra.Command {
if httpsAddr == "" { if httpsAddr == "" {
httpsAddr = "0.0.0.0:443" httpsAddr = "0.0.0.0:443"
} }
} else {
if httpAddr == "" {
httpAddr = "127.0.0.1:8090"
}
} }
_, err := apis.Serve(app, apis.ServeConfig{ _, err := apis.Serve(app, apis.ServeConfig{