colin
/
pocketbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[#2726] removed unnecessary Dao().TotalAdmins() call

This commit is contained in:
Sven-Kristjan Kompus 2023-06-16 14:43:05 +03:00 committed by GitHub
parent d1bcaa65b1
commit caf343ef9c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
apis/middlewares.go
View File

@ -129,14 +129,17 @@ func RequireAdminAuth() echo.MiddlewareFunc {
func RequireAdminAuthOnlyIfAny(app core.App) echo.MiddlewareFunc { func RequireAdminAuthOnlyIfAny(app core.App) echo.MiddlewareFunc {
return func(next echo.HandlerFunc) echo.HandlerFunc { return func(next echo.HandlerFunc) echo.HandlerFunc {
return func(c echo.Context) error { return func(c echo.Context) error {
admin, _ := c.Get(ContextAdminKey).(*models.Admin)
if admin != nil {
return next(c)
}
totalAdmins, err := app.Dao().TotalAdmins() totalAdmins, err := app.Dao().TotalAdmins()
if err != nil { if err != nil {
return NewBadRequestError("Failed to fetch admins info.", err) return NewBadRequestError("Failed to fetch admins info.", err)
} }
admin, _ := c.Get(ContextAdminKey).(*models.Admin) if totalAdmins == 0 {
if admin != nil || totalAdmins == 0 {
return next(c) return next(c)
} }